From: Andrew Lunn <andrew@lunn.ch>
To: Christian Melki <christian.melki@t2data.com>
Cc: kuba@kernel.org, hkallweit1@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v3 net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081
Date: Thu, 25 Feb 2021 02:59:51 +0100 [thread overview]
Message-ID: <YDcEl2vPZ5XABMsR@lunn.ch> (raw)
In-Reply-To: <20210224205536.9349-1-christian.melki@t2data.com>
On Wed, Feb 24, 2021 at 09:55:36PM +0100, Christian Melki wrote:
> Following a similar reinstate for the KSZ9031.
>
> Older kernels would use the genphy_soft_reset if the PHY did not implement
> a .soft_reset.
>
> Bluntly removing that default may expose a lot of situations where various
> PHYs/board implementations won't recover on various changes.
> Like with this implementation during a 4.9.x to 5.4.x LTS transition.
> I think it's a good thing to remove unwanted soft resets but wonder if it
> did open a can of worms?
>
> Atleast this fixes one iMX6 FEC/RMII/8081 combo.
>
> Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset")
> Signed-off-by: Christian Melki <christian.melki@t2data.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2021-02-25 2:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 20:55 [PATCH v3 net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ8081 Christian Melki
2021-02-25 1:59 ` Andrew Lunn [this message]
2021-02-25 17:52 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDcEl2vPZ5XABMsR@lunn.ch \
--to=andrew@lunn.ch \
--cc=christian.melki@t2data.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).