From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE9E4C433E0 for ; Thu, 25 Feb 2021 13:33:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B3DB64ED3 for ; Thu, 25 Feb 2021 13:33:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229722AbhBYNdH (ORCPT ); Thu, 25 Feb 2021 08:33:07 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:57420 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232471AbhBYNcE (ORCPT ); Thu, 25 Feb 2021 08:32:04 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lFGjY-008PSW-DE; Thu, 25 Feb 2021 14:31:12 +0100 Date: Thu, 25 Feb 2021 14:31:12 +0100 From: Andrew Lunn To: Joakim Zhang Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org, f.fainelli@gmail.com, linux-imx@nxp.com, netdev@vger.kernel.org Subject: Re: [RFC V2 net-next 1/3] net: stmmac: add clocks management for gmac driver Message-ID: References: <20210225115050.23971-1-qiangqing.zhang@nxp.com> <20210225115050.23971-2-qiangqing.zhang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210225115050.23971-2-qiangqing.zhang@nxp.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > @@ -248,9 +296,15 @@ static int stmmac_mdio_write(struct mii_bus *bus, int phyaddr, int phyreg, > unsigned int mii_address = priv->hw->mii.addr; > unsigned int mii_data = priv->hw->mii.data; > u32 value = MII_BUSY; > - int data = phydata; > + int ret, data = phydata; > u32 v; Reverse Christmass tree. Otherwise this looks good. Andrew