From: Andrew Lunn <andrew@lunn.ch>
To: "Daniel González Cabanelas" <dgcbueu@gmail.com>
Cc: "Heiner Kallweit" <hkallweit1@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
gregkh@linuxfoundation.org, netdev@vger.kernel.org,
"Álvaro Fernández Rojas" <noltari@gmail.com>
Subject: Re: [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment
Date: Fri, 26 Feb 2021 15:16:12 +0100 [thread overview]
Message-ID: <YDkCrCIwtCOmOBAX@lunn.ch> (raw)
In-Reply-To: <CABwr4_tJqFiS-XtFitXGn=bjYzdv=YwqSSUaAvh1U-iHsbTZXQ@mail.gmail.com>
> > OK, I see. Then there's no reason to complain upstream.
> > Either use the mainline B53 DSA driver of fix interrupt mode
> > downstream.
>
> I agree.
>
> This b53 driver has one PHY with the same BCM63XX phy_id, causing a
> double probe. I'll send the original patch to the OpenWrt project.
Hi Daniel
There is a bit of a disconnect between OpenWRT and Mainline. They have
a lot of fixes that don't make it upstream. So it is good to see
somebody trying to fix mainline first, and then backport to
OpenWRT. But please do test mainline and confirm it is actually broken
before submitting patches.
When you do submit to OpenWRT, please make it clear this is an OpenWRT
problem so somebody does not try to push it to mainline again....
And if you have an itch to scratch, try adding mainline support for
this board. We can guide you.
Andrew
next prev parent reply other threads:[~2021-02-26 14:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 15:44 [PATCH v2] bcm63xx_enet: fix internal phy IRQ assignment Daniel González Cabanelas
2021-02-24 21:44 ` Heiner Kallweit
2021-02-24 22:01 ` Florian Fainelli
2021-02-24 23:54 ` Daniel González Cabanelas
2021-02-25 7:22 ` Heiner Kallweit
2021-02-25 16:36 ` Daniel González Cabanelas
2021-02-25 20:05 ` Heiner Kallweit
2021-02-25 22:28 ` Daniel González Cabanelas
2021-02-25 22:56 ` Heiner Kallweit
2021-02-26 4:12 ` Florian Fainelli
2021-02-26 7:13 ` Heiner Kallweit
2021-02-26 9:10 ` Daniel González Cabanelas
2021-02-26 9:32 ` Heiner Kallweit
2021-02-26 9:38 ` Heiner Kallweit
2021-02-26 9:49 ` Daniel González Cabanelas
2021-02-26 10:08 ` Heiner Kallweit
2021-02-26 10:19 ` Daniel González Cabanelas
2021-02-26 14:16 ` Andrew Lunn [this message]
2021-02-26 14:28 ` Heiner Kallweit
2021-02-26 16:14 ` Daniel González Cabanelas
2021-02-26 16:55 ` Florian Fainelli
2021-02-25 13:53 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDkCrCIwtCOmOBAX@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dgcbueu@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noltari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).