From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94540C433E6 for ; Mon, 1 Mar 2021 14:45:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BF4E64DF5 for ; Mon, 1 Mar 2021 14:45:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236512AbhCAOpk (ORCPT ); Mon, 1 Mar 2021 09:45:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:33132 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236529AbhCAOp3 (ORCPT ); Mon, 1 Mar 2021 09:45:29 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 101366146D; Mon, 1 Mar 2021 14:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614609888; bh=gi3PWvwXbOKCcgAcvlCDXJn1emBHZl2qG3u8e58yiyo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aP/ibswuZgNlJxIClWLKfrz+hdXFDZY1U+Z+D4jx9gP0WREwOpwU0i+ptJaOru/cx YXmRkvebFMxHXXYKpa10USfXDiIB6uP1nMrBgPrOeue6/G2mlnJUnobTvVcUEMuX2e QyAY7o6yx347EqM9iEEpHJZwWphuMD+rT3Kz+28KND6qPM6erb8/lpUnNuJ8T+ut9y yt6o2T/i6JEdr/CVGHYfJ8bOCcKGwRJ5X5KZJm7691lND2FUhGiNeHeTq0WBZxD003 +NzgHtY//Ff6MLof1knCgHae6oe48FKOJTUPjY8CS/G3oEHhEWMQ7P8anpRf4QuZ9h 6MNfCTet9KZXw== Date: Mon, 1 Mar 2021 16:44:45 +0200 From: Leon Romanovsky To: Jason Gunthorpe Cc: Doug Ledford , Mark Bloch , Adit Ranadive , Ariel Elior , Bart Van Assche , Bernard Metzler , Christian Benvenuti , Dennis Dalessandro , Devesh Sharma , Faisal Latif , Gal Pressman , Jakub Kicinski , Lijun Ou , linux-rdma@vger.kernel.org, Michal Kalderon , Mike Marciniszyn , Naresh Kumar PBS , Nelson Escobar , netdev@vger.kernel.org, Potnuri Bharat Teja , Saeed Mahameed , Selvin Xavier , Shiraz Saleem , Somnath Kotur , Sriharsha Basavapatna , target-devel@vger.kernel.org, VMware PV-Drivers , Weihang Li , "Wei Hu(Xavier)" , Yishai Hadas , Zhu Yanjun Subject: Re: [PATCH rdma-next] RDMA: Support more than 255 rdma ports Message-ID: References: <20210301070420.439400-1-leon@kernel.org> <20210301124834.GE4247@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210301124834.GE4247@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 01, 2021 at 08:48:34AM -0400, Jason Gunthorpe wrote: > On Mon, Mar 01, 2021 at 09:04:20AM +0200, Leon Romanovsky wrote: > > @@ -884,7 +884,7 @@ static void gid_table_reserve_default(struct ib_device *ib_dev, u8 port, > > > > static void gid_table_release_one(struct ib_device *ib_dev) > > { > > - unsigned int p; > > + u32 p; > > > > rdma_for_each_port (ib_dev, p) { > > release_gid_table(ib_dev, ib_dev->port_data[p].cache.gid); > > @@ -895,7 +895,7 @@ static void gid_table_release_one(struct ib_device *ib_dev) > > static int _gid_table_setup_one(struct ib_device *ib_dev) > > { > > struct ib_gid_table *table; > > - unsigned int rdma_port; > > + u32 rdma_port; > > > > rdma_for_each_port (ib_dev, rdma_port) { > > Why are we changing this? 'unsigned int' is the right type for port > numbers I prefer to see same types in all places. We use u32 for HW data and netlink, so it makes sense to have it everywhere. Also, at least for me, the u32 is more explicit than "unsigned int". So when Mark asked me which type to use, I said u32. Thanks > > Jason