From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6ED5C433E0 for ; Thu, 4 Mar 2021 13:37:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 712F364F41 for ; Thu, 4 Mar 2021 13:37:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241316AbhCDNgT (ORCPT ); Thu, 4 Mar 2021 08:36:19 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:39856 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240738AbhCDNgD (ORCPT ); Thu, 4 Mar 2021 08:36:03 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lHo8N-009I9c-Gh; Thu, 04 Mar 2021 14:35:19 +0100 Date: Thu, 4 Mar 2021 14:35:19 +0100 From: Andrew Lunn To: Vladimir Oltean Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, vivien.didelot@gmail.com, f.fainelli@gmail.com, Vladimir Oltean Subject: Re: [PATCH net 2/2] net: dsa: sja1105: fix ucast/bcast flooding always remaining enabled Message-ID: References: <20210304105654.873554-1-olteanv@gmail.com> <20210304105654.873554-2-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210304105654.873554-2-olteanv@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Mar 04, 2021 at 12:56:54PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > In the blamed patch I managed to introduce a bug while moving code > around: the same logic is applied to the ucast_egress_floods and > bcast_egress_floods variables both on the "if" and the "else" branches. Some static analysers will report this. > This is clearly an unintended change compared to how the code used to be > prior to that bugfix, so restore it. > > Fixes: 7f7ccdea8c73 ("net: dsa: sja1105: fix leakage of flooded frames outside bridging domain") > Signed-off-by: Vladimir Oltean Reviewed-by: Andrew Lunn Andrew