From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DA57C433E6 for ; Fri, 5 Mar 2021 04:54:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2EEE65005 for ; Fri, 5 Mar 2021 04:54:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229648AbhCEEyY (ORCPT ); Thu, 4 Mar 2021 23:54:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbhCEEyX (ORCPT ); Thu, 4 Mar 2021 23:54:23 -0500 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D81C9C061574 for ; Thu, 4 Mar 2021 20:54:21 -0800 (PST) Received: by mail-ot1-x329.google.com with SMTP id v12so614316ott.10 for ; Thu, 04 Mar 2021 20:54:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=v5vUH7jZFg89PccMthKJVQxPCOGJqn1GXklu4BKBrBs=; b=JuvOf4VVEYS89LfkQM53QREtjLbjv+M6xBZrd6lInijt/o4C39mz4CXUCN78+4APWG cLRHwmUDY7sOY0CJpIUt1MLqwEwkp1q0GYdNbESH1KjA3aDqbVR9FDVoTXe1Sk9Xr16U EDSsihGqbI4f6atWBiikbF9SUDcJpOuV44QOr6gLiZUUCkfV1dI/pBntjWMZppicxZWJ dW8KwZrWbsQoLFVRzDCdhfr557JEkWfkC0+deY/U34AU8tJqLLVo3B8S1/pcJ5PtfxrD GvEXPoJhZuSf2/8yRzyJEEiLXWaCpRkPfP9OOoYp2RR3FRJFbcdI5OqtY7LaOFRiJL/R /kPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=v5vUH7jZFg89PccMthKJVQxPCOGJqn1GXklu4BKBrBs=; b=IHTjtTswUQ0AWEEgzPBl5SXtYN7WFuA+UutHLsTmGq0W8Adv8+rVQlPVcYmASEHDJk bENVoVygeoW9CwMMKwU0LZG0XTeAFdegJKwIZSTc5OBZDdELLfVyz3cATBcEMV37t97Z gRrERODy9HxNo+0NFVLWwW5/gYxGH27F9w5NOYROloGwlPAyDLYI5WkHHr9Qt/BbcbjQ kEvXUf8UxuDlVAxkRT0oQecWfhGXy3Zjy6fhH0fsDYWcZYWJC1JMlMKbfJmVJC/H8A5B Nveb4DZ7UVLPpjwacfe6lSGUYhudIHpmU+72WsrOE8mUILB7tyf73otNTZkP5QrDdA6j 7HVg== X-Gm-Message-State: AOAM530EfBp8dPMQtJzN+2fOuSkZYfzPcze4lhO8E1GDzv/kZedYcvSu U3FGRgzm5lJoSXQjIW9gqM64Vw== X-Google-Smtp-Source: ABdhPJx8mwLwoYpU80IxbM0PI2U+kNY5M/A1Cshqk+6PQRbHjEc7b3FUZ69dHwffF+iR/BW9pkEVGQ== X-Received: by 2002:a9d:7196:: with SMTP id o22mr6403661otj.107.1614920061290; Thu, 04 Mar 2021 20:54:21 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id c25sm400317otk.35.2021.03.04.20.54.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Mar 2021 20:54:20 -0800 (PST) Date: Thu, 4 Mar 2021 22:54:19 -0600 From: Bjorn Andersson To: Alex Elder Cc: subashab@codeaurora.org, stranche@codeaurora.org, davem@davemloft.net, kuba@kernel.org, sharathv@codeaurora.org, evgreen@chromium.org, cpratapa@codeaurora.org, elder@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 5/6] net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum trailer Message-ID: References: <20210304223431.15045-1-elder@linaro.org> <20210304223431.15045-6-elder@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210304223431.15045-6-elder@linaro.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu 04 Mar 16:34 CST 2021, Alex Elder wrote: > Replace the use of C bit-fields in the rmnet_map_dl_csum_trailer > structure with a single one-byte field, using constant field masks > to encode or get at embedded values. > Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Alex Elder > --- > .../ethernet/qualcomm/rmnet/rmnet_map_data.c | 2 +- > include/linux/if_rmnet.h | 17 +++++++---------- > 2 files changed, 8 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c > index 3291f252d81b0..29d485b868a65 100644 > --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c > +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c > @@ -365,7 +365,7 @@ int rmnet_map_checksum_downlink_packet(struct sk_buff *skb, u16 len) > > csum_trailer = (struct rmnet_map_dl_csum_trailer *)(skb->data + len); > > - if (!csum_trailer->valid) { > + if (!u8_get_bits(csum_trailer->flags, MAP_CSUM_DL_VALID_FMASK)) { > priv->stats.csum_valid_unset++; > return -EINVAL; > } > diff --git a/include/linux/if_rmnet.h b/include/linux/if_rmnet.h > index 4824c6328a82c..1fbb7531238b6 100644 > --- a/include/linux/if_rmnet.h > +++ b/include/linux/if_rmnet.h > @@ -19,21 +19,18 @@ struct rmnet_map_header { > #define MAP_PAD_LEN_FMASK GENMASK(5, 0) > > struct rmnet_map_dl_csum_trailer { > - u8 reserved1; > -#if defined(__LITTLE_ENDIAN_BITFIELD) > - u8 valid:1; > - u8 reserved2:7; > -#elif defined (__BIG_ENDIAN_BITFIELD) > - u8 reserved2:7; > - u8 valid:1; > -#else > -#error "Please fix " > -#endif > + u8 reserved1; > + u8 flags; /* MAP_CSUM_DL_*_FMASK */ > __be16 csum_start_offset; > __be16 csum_length; > __be16 csum_value; > } __aligned(1); > > +/* rmnet_map_dl_csum_trailer flags field: > + * VALID: 1 = checksum and length valid; 0 = ignore them > + */ > +#define MAP_CSUM_DL_VALID_FMASK GENMASK(0, 0) > + > struct rmnet_map_ul_csum_header { > __be16 csum_start_offset; > #if defined(__LITTLE_ENDIAN_BITFIELD) > -- > 2.20.1 >