From: Andrew Lunn <andrew@lunn.ch>
To: Moshe Shemesh <moshe@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Adrian Pop <pop.adrian61@gmail.com>,
Michal Kubecek <mkubecek@suse.cz>,
Don Bollinger <don@thebollingers.org>,
netdev@vger.kernel.org,
Vladyslav Tarasiuk <vladyslavt@nvidia.com>
Subject: Re: [RFC PATCH V2 net-next 1/5] ethtool: Allow network drivers to dump arbitrary EEPROM data
Date: Fri, 5 Mar 2021 02:58:29 +0100 [thread overview]
Message-ID: <YEGQRW9cYK7pHOC7@lunn.ch> (raw)
In-Reply-To: <1614884228-8542-2-git-send-email-moshe@nvidia.com>
> +/* MODULE EEPROM DATA */
> +
> +enum {
> + ETHTOOL_A_EEPROM_DATA_UNSPEC,
> + ETHTOOL_A_EEPROM_DATA_HEADER,
> +
> + ETHTOOL_A_EEPROM_DATA_OFFSET,
> + ETHTOOL_A_EEPROM_DATA_LENGTH,
> + ETHTOOL_A_EEPROM_DATA_PAGE,
> + ETHTOOL_A_EEPROM_DATA_BANK,
> + ETHTOOL_A_EEPROM_DATA_I2C_ADDRESS,
> + ETHTOOL_A_EEPROM_DATA,
If you look at all the other such enums in ethtool_netlink, you will
see a comment indicating the type. Please add them here as well.
Please also update Documentation/networking/ethtool-netlink.rst.
Andrew
next prev parent reply other threads:[~2021-03-05 1:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 18:57 [RFC PATCH V2 net-next 0/5] ethtool: Extend module EEPROM dump API Moshe Shemesh
2021-03-04 18:57 ` [RFC PATCH V2 net-next 1/5] ethtool: Allow network drivers to dump arbitrary EEPROM data Moshe Shemesh
2021-03-05 0:50 ` Don Bollinger
2021-03-05 1:32 ` Andrew Lunn
2021-03-08 8:45 ` Moshe Shemesh
2021-03-05 1:58 ` Andrew Lunn [this message]
2021-03-08 8:54 ` Moshe Shemesh
2021-03-04 18:57 ` [RFC PATCH V2 net-next 2/5] net/mlx5: Refactor module EEPROM query Moshe Shemesh
2021-03-04 18:57 ` [RFC PATCH V2 net-next 3/5] net/mlx5: Implement get_module_eeprom_data_by_page() Moshe Shemesh
2021-03-04 18:57 ` [RFC PATCH V2 net-next 4/5] net/mlx5: Add support for DSFP module EEPROM dumps Moshe Shemesh
2021-03-04 18:57 ` [RFC PATCH V2 net-next 5/5] ethtool: Add fallback to get_module_eeprom from netlink command Moshe Shemesh
2021-03-05 0:50 ` Don Bollinger
2021-03-05 1:50 ` Andrew Lunn
2021-03-05 2:44 ` Don Bollinger
2021-03-05 2:53 ` Don Bollinger
2021-03-08 9:04 ` Moshe Shemesh
2021-03-05 0:50 ` [RFC PATCH V2 net-next 0/5] ethtool: Extend module EEPROM dump API Don Bollinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEGQRW9cYK7pHOC7@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=don@thebollingers.org \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pop.adrian61@gmail.com \
--cc=vladyslavt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).