From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3454C433DB for ; Sun, 7 Mar 2021 12:30:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73BFE650FA for ; Sun, 7 Mar 2021 12:30:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230286AbhCGM3O (ORCPT ); Sun, 7 Mar 2021 07:29:14 -0500 Received: from mail.kernel.org ([198.145.29.99]:44240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229662AbhCGM2q (ORCPT ); Sun, 7 Mar 2021 07:28:46 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0CBF965092; Sun, 7 Mar 2021 12:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615120125; bh=sY1HN2BTEJut9YpU7t00t6v+TXQSn/Gf4U69FgfKcdA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=POrEybZ4F4prA4n+UYe5izD5Imvnkvyrvg84/Wm2SjlPL/UtSYD2BQw7BAgTN2XJ0 BsaM2lMocTWp50+LIdiD6vC8JSHyhGEQZlFogbRSj8lLUIGIJullcNSmUmQoy2IIbH NrobhxecgRpV4PN/mLlhSXElykQrjTkA5nktYU2R73k35eeIjrDqHfJcukhlewCVNN Thpak2cAvfNisOG3xxWDTLGQjh8WuTBhM62r7HAMP/CgqeUW5i9bpPI2wnUGnA/Riu 2VRTewB1gXn91YhQmf2aBaAWtQmo89BIv5GUSmtmJarZLXr3hGIJ638q3HeFwdj1kD Xkqs62JEf9U0A== Date: Sun, 7 Mar 2021 14:28:40 +0200 From: Leon Romanovsky To: Jia-Ju Bai Cc: davem@davemloft.net, kuba@kernel.org, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ath: ath6kl: fix error return code of ath6kl_htc_rx_bundle() Message-ID: References: <20210307090757.22617-1-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Mar 07, 2021 at 05:31:01PM +0800, Jia-Ju Bai wrote: > Hi Leon, > > I am quite sorry for my incorrect patches... > My static analysis tool reports some possible bugs about error handling > code, and thus I write some patches for the bugs that seem to be true in my > opinion. > Because I am not familiar with many device drivers, some of my reported bugs > can be false positives... It will be much helpful if instead of writing new static analysis tool, you will invest time and improve existing well known tools, like smatch and sparse. Right now, you didn't report bugs, but sent bunch of patches that most of the time are incorrect. So it is not "some of my reported bugs can be false positives...", but "some of my patches can fix real bugs by chance". Thanks