From: Christoph Hellwig <hch@infradead.org>
To: Felix Manlunas <felix.manlunas@cavium.com>,
Derek Chickles <dchickles@marvell.com>,
Satanand Burla <sburla@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: module refcount issues in the liquidio driver
Date: Thu, 11 Mar 2021 08:37:32 +0100 [thread overview]
Message-ID: <YEnIvMOComLaaVa5@infradead.org> (raw)
Hi all,
I just stumbled over the odd handling of module refcounts in the liquidio
driver. The big red flag is the call to module_refcount in
liquidio_watchdog, which will do the wrong thing for any external module
refcount, like a userspace open.
But more importantly the whole concept of acquiring module refcounts from
inside the driver is pretty bogus. What problem does this try to solve?
next reply other threads:[~2021-03-11 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 7:37 Christoph Hellwig [this message]
2021-03-11 17:43 ` [EXT] module refcount issues in the liquidio driver Felix Manlunas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEnIvMOComLaaVa5@infradead.org \
--to=hch@infradead.org \
--cc=dchickles@marvell.com \
--cc=felix.manlunas@cavium.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sburla@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).