From: Andrew Lunn <andrew@lunn.ch>
To: Robert Hancock <robert.hancock@calian.com>
Cc: davem@davemloft.net, kuba@kernel.org,
radhey.shyam.pandey@xilinx.com, robh@kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v4 2/2] net: axienet: Enable more clocks
Date: Fri, 26 Mar 2021 13:14:48 +0100 [thread overview]
Message-ID: <YF3QOFw7jREj03Ut@lunn.ch> (raw)
In-Reply-To: <20210326000438.2292548-3-robert.hancock@calian.com>
On Thu, Mar 25, 2021 at 06:04:38PM -0600, Robert Hancock wrote:
> This driver was only enabling the first clock on the device, regardless
> of its name. However, this controller logic can have multiple clocks
> which should all be enabled. Add support for enabling additional clocks.
> The clock names used are matching those used in the Xilinx version of this
> driver as well as the Xilinx device tree generator, except for mgt_clk
> which is not present there.
>
> For backward compatibility, if no named clocks are present, the first
> clock present is used for determining the MDIO bus clock divider.
>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> Signed-off-by: Robert Hancock <robert.hancock@calian.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2021-03-26 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 0:04 [PATCH net-next v4 0/2] axienet clock additions Robert Hancock
2021-03-26 0:04 ` [PATCH net-next v4 1/2] dt-bindings: net: xilinx_axienet: Document additional clocks Robert Hancock
2021-03-26 12:12 ` Andrew Lunn
2021-03-26 0:04 ` [PATCH net-next v4 2/2] net: axienet: Enable more clocks Robert Hancock
2021-03-26 12:14 ` Andrew Lunn [this message]
2021-03-26 23:00 ` [PATCH net-next v4 0/2] axienet clock additions patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF3QOFw7jREj03Ut@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=robert.hancock@calian.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).