From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
ecree.xilinx@gmail.com, michael.chan@broadcom.com,
paul.greenwalt@intel.com, rajur@chelsio.com,
jaroslawx.gawin@intel.com, vkochan@marvell.com, alobakin@pm.me,
snelson@pensando.io, shayagr@amazon.com, ayal@nvidia.com,
shenjian15@huawei.com, saeedm@nvidia.com, mkubecek@suse.cz,
roopa@nvidia.com
Subject: Re: [PATCH net-next v2 6/6] ethtool: clarify the ethtool FEC interface
Date: Fri, 26 Mar 2021 13:20:28 +0100 [thread overview]
Message-ID: <YF3RjFWaFg7TMwgQ@lunn.ch> (raw)
In-Reply-To: <20210326020727.246828-7-kuba@kernel.org>
On Thu, Mar 25, 2021 at 07:07:27PM -0700, Jakub Kicinski wrote:
> The definition of the FEC driver interface is quite unclear.
> Improve the documentation.
>
> This is based on current driver and user space code, as well
> as the discussions about the interface:
>
> RFC v1 (24 Oct 2016): https://lore.kernel.org/netdev/1477363849-36517-1-git-send-email-vidya@cumulusnetworks.com/
> - this version has the autoneg field
> - no active_fec field
> - none vs off confusion is already present
>
> RFC v2 (10 Feb 2017): https://lore.kernel.org/netdev/1486727004-11316-1-git-send-email-vidya@cumulusnetworks.com/
> - autoneg removed
> - active_fec added
>
> v1 (10 Feb 2017): https://lore.kernel.org/netdev/1486751311-42019-1-git-send-email-vidya@cumulusnetworks.com/
> - no changes in the code
>
> v1 (24 Jun 2017): https://lore.kernel.org/netdev/1498331985-8525-1-git-send-email-roopa@cumulusnetworks.com/
> - include in tree user
>
> v2 (27 Jul 2017): https://lore.kernel.org/netdev/1501199248-24695-1-git-send-email-roopa@cumulusnetworks.com/
>
> v2: - make enum kdoc reference bits
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2021-03-26 12:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 2:07 [PATCH net-next v2 0/6] ethtool: clarify the ethtool FEC interface Jakub Kicinski
2021-03-26 2:07 ` [PATCH net-next v2 1/6] ethtool: fec: fix typo in kdoc Jakub Kicinski
2021-03-26 2:07 ` [PATCH net-next v2 2/6] ethtool: fec: remove long structure description Jakub Kicinski
2021-03-26 2:07 ` [PATCH net-next v2 3/6] ethtool: fec: sanitize ethtool_fecparam->reserved Jakub Kicinski
2021-03-26 12:17 ` Andrew Lunn
2021-03-26 2:07 ` [PATCH net-next v2 4/6] ethtool: fec: sanitize ethtool_fecparam->active_fec Jakub Kicinski
2021-03-26 2:07 ` [PATCH net-next v2 5/6] ethtool: fec: sanitize ethtool_fecparam->fec Jakub Kicinski
2021-03-26 12:18 ` Andrew Lunn
2021-03-26 2:07 ` [PATCH net-next v2 6/6] ethtool: clarify the ethtool FEC interface Jakub Kicinski
2021-03-26 12:20 ` Andrew Lunn [this message]
2021-03-26 21:49 ` [PATCH net-next v2 0/6] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF3RjFWaFg7TMwgQ@lunn.ch \
--to=andrew@lunn.ch \
--cc=alobakin@pm.me \
--cc=ayal@nvidia.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=jaroslawx.gawin@intel.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=paul.greenwalt@intel.com \
--cc=rajur@chelsio.com \
--cc=roopa@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=shayagr@amazon.com \
--cc=shenjian15@huawei.com \
--cc=snelson@pensando.io \
--cc=vkochan@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).