From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Oz Shlomo <ozsh@nvidia.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
Saeed Mahameed <saeedm@nvidia.com>,
Paul Blakey <paulb@nvidia.com>
Subject: Re: [PATCH nf-next] netfilter: flowtable: separate replace, destroy and stats to different workqueues
Date: Fri, 26 Mar 2021 10:51:49 -0300 [thread overview]
Message-ID: <YF3m9Xt3DosPr36e@horizon.localdomain> (raw)
In-Reply-To: <b89d8340-ca1c-1424-bbaa-0e85d37a84bb@nvidia.com>
On Thu, Mar 25, 2021 at 10:46:12AM +0200, Oz Shlomo wrote:
> Hi Marcelo,
>
> On 3/24/2021 11:20 PM, Marcelo Ricardo Leitner wrote:
> > Maybe I'm just missing it but I'm not seeing how removals would only
> > happen after the entry is actually offloaded. As in, if the add queue
> > is very long, and the datapath see a FIN, seems the next gc iteration
> > could try to remove it before it's actually offloaded. I think this is
> > what Pablo meant on his original reply here too, then his idea on
> > having add/del to work with the same queue.
> >
>
> The work item will not be allocated if the hw offload is pending.
>
> nf_flow_offload_work_alloc()
> if (test_and_set_bit(NF_FLOW_HW_PENDING, &flow->flags))
> return NULL;
Ahá! Right, and with that there can only be 1 flow_offload_work for a
flow at a time, so it can't fetch stats for a flow that is still to be
offloaded too. Got it.
Thanks,
Marcelo
next prev parent reply other threads:[~2021-03-26 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 12:59 [PATCH nf-next] netfilter: flowtable: separate replace, destroy and stats to different workqueues Oz Shlomo
2021-03-03 16:11 ` Pablo Neira Ayuso
2021-03-22 18:09 ` Marcelo Ricardo Leitner
2021-03-24 1:38 ` Pablo Neira Ayuso
2021-03-24 11:24 ` Oz Shlomo
2021-03-24 21:20 ` Marcelo Ricardo Leitner
2021-03-25 8:46 ` Oz Shlomo
2021-03-26 13:51 ` Marcelo Ricardo Leitner [this message]
2021-03-17 23:36 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YF3m9Xt3DosPr36e@horizon.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=ozsh@nvidia.com \
--cc=pablo@netfilter.org \
--cc=paulb@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox