From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB85BC433E6 for ; Thu, 18 Mar 2021 14:51:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0C9B64F2B for ; Thu, 18 Mar 2021 14:51:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231572AbhCROvF (ORCPT ); Thu, 18 Mar 2021 10:51:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231429AbhCROuz (ORCPT ); Thu, 18 Mar 2021 10:50:55 -0400 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90493C061760 for ; Thu, 18 Mar 2021 07:50:55 -0700 (PDT) Received: by mail-oi1-x22f.google.com with SMTP id n8so1316951oie.10 for ; Thu, 18 Mar 2021 07:50:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=og89K6jV3HFX8PE96KX/c5Zy0nyRjtFamlhCSJhcZac=; b=BbZoR5bKJdUlBsWePVP9pZFO52LSwx83bqvlA+iFEHEJbXRLCIjazsIWJ7Viy6/Dqg ms11HMn9qzvtUSKYV7kiYroJ8GoudjnuRaAotpDXCJkiH2454Zsrw0r8xOeT1eDT6YxS q+3+MBnu38qnO454OYLGBpBP8Gq2YHx7vcVu1igvYYB7TkhTKWyAqpE95EEQZcA7yNgB R/S0blHSK+wctWLHT5XamyOYHV+RON+tPa7QPNHdEwmYkO7LDY4BJHU3BGXMaxeArqVY EZJyG7pBZFDAX8JWQxpbOFMez+cg1l1eLriE/6/arkjyVorRKAMnxrrUHlTsEIB5mVvO PCAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=og89K6jV3HFX8PE96KX/c5Zy0nyRjtFamlhCSJhcZac=; b=LROUJonmgA4Rk2tE0w2XQF9YEiOLNIUlShn3SVAb2G7ViQCFYKjLiT2xSt2qZ6AMpv x6umKjLB/06eBydkM9Oh4K4jIQ++AcRZ8HLh0VPqSAmynKsArILufcTJ8Wy5sR/bJQuw aiTQoxLdQRRn/HIi+j5V2GPKOjuhNobszlgGNRPNmNat3F7dm25llyY6AyOjgTEl2VMO v2vTaqMVc8/hnTYRHhBgtGzvXLiu80rBfalv0pa8fr/PW0AcW3grvkhoXvhVvI9BJbfl SUCEvwdvDTyWgQY+EADXl8hhBVteAYV+ZTiY0jF1gi/cZxFd8saktvhTgxvnzCloD8eu ccWw== X-Gm-Message-State: AOAM531wV1ElhSJEJjZfTnQvIKRpbC6ENx+Om7Ke+C0i/mZp0Cn/V0CM C5e2rt6etohcs0yOlOGhcRF1Cw== X-Google-Smtp-Source: ABdhPJw88D0okVHzO8aCSbNOnCSK+c61zfhIoBhm9ubX4GrgcqtKVy0DZAl00IvFZIUH6e7eT8sHOA== X-Received: by 2002:a05:6808:987:: with SMTP id a7mr3198012oic.162.1616079054839; Thu, 18 Mar 2021 07:50:54 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id r13sm594897oot.41.2021.03.18.07.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 07:50:54 -0700 (PDT) Date: Thu, 18 Mar 2021 09:50:52 -0500 From: Bjorn Andersson To: Bryan O'Donoghue Cc: Andy Gross , Rob Herring , Kalle Valo , "David S. Miller" , Jakub Kicinski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 5/5] arm64: dts: qcom: msm8916: Enable modem and WiFi Message-ID: References: <20210312003318.3273536-1-bjorn.andersson@linaro.org> <20210312003318.3273536-6-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon 15 Mar 07:01 CDT 2021, Bryan O'Donoghue wrote: > On 12/03/2021 00:33, Bjorn Andersson wrote: > > Enable the modem and WiFi subsystems and specify msm8916 specific > > firmware path for these and the WCNSS control service. > > > > Signed-off-by: Bjorn Andersson > > --- > > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 12 ++++++++++++ > > arch/arm64/boot/dts/qcom/msm8916.dtsi | 2 +- > > 2 files changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > > index 6aef0c2e4f0a..448e3561ef63 100644 > > --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > > @@ -305,6 +305,12 @@ &mdss { > > status = "okay"; > > }; > > +&mpss { > > + status = "okay"; > > + > > + firmware-name = "qcom/msm8916/mba.mbn", "qcom/msm8916/modem.mbn"; > > +}; > > + > > &pm8916_resin { > > status = "okay"; > > linux,code = ; > > @@ -312,6 +318,8 @@ &pm8916_resin { > > &pronto { > > status = "okay"; > > + > > + firmware-name = "qcom/msm8916/wcnss.mbn"; > > }; > > On Debian I have to do this > > > index 2a6a23cb14ca..597cdc8f51cc 100644 > --- a/drivers/remoteproc/qcom_wcnss.c > +++ b/drivers/remoteproc/qcom_wcnss.c > @@ -33,7 +33,7 @@ > #include "qcom_wcnss.h" > > #define WCNSS_CRASH_REASON_SMEM 422 > -#define WCNSS_FIRMWARE_NAME "wcnss.mdt" > +#define WCNSS_FIRMWARE_NAME "qcom/msm8916/wcnss.mdt" > > so I guess wcnss_probe() -> rproc_alloc() wants this fix too. > Can you confirm that you're saying that you want below patch, which I just merged? https://lore.kernel.org/linux-remoteproc/20210312002441.3273183-1-bjorn.andersson@linaro.org/ (Which makes it possible to specify firmware name per platform/board) Regards, Bjorn