From: Andrew Lunn <andrew@lunn.ch>
To: Bjarni Jonasson <bjarni.jonasson@microchip.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Antoine Tenart <atenart@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Quentin Schulz <quentin.schulz@bootlin.com>,
Michael Walle <michael@walle.cc>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
UNGLinuxDriver <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next v1 2/3] net: phy: mscc: improved serdes calibration applied to VSC8584
Date: Thu, 18 Mar 2021 21:45:00 +0100 [thread overview]
Message-ID: <YFO7zN9iUMelyCdD@lunn.ch> (raw)
In-Reply-To: <20210318123851.10324-3-bjarni.jonasson@microchip.com>
On Thu, Mar 18, 2021 at 01:38:50PM +0100, Bjarni Jonasson wrote:
> -static int vsc8584_config_init(struct phy_device *phydev)
> +static int vsc8584_config_host_serdes(struct phy_device *phydev)
> {
> - struct vsc8531_private *vsc8531 = phydev->priv;
> - int ret, i;
> + int ret;
> u16 val;
> + struct vsc8531_private *vsc8531 = phydev->priv;
Reverse christmass tree.
> +static int vsc8574_config_host_serdes(struct phy_device *phydev)
> +{
> + int ret;
> + u16 val;
> + struct vsc8531_private *vsc8531 = phydev->priv;
Here as well
Andrew
next prev parent reply other threads:[~2021-03-18 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 12:38 [PATCH net-next v1 0/3] Fixes applied to VCS8584 family Bjarni Jonasson
2021-03-18 12:38 ` [PATCH net-next v1 1/3] net: phy: mscc: Applying LCPLL reset to VSC8584 Bjarni Jonasson
2021-03-18 12:38 ` [PATCH net-next v1 2/3] net: phy: mscc: improved serdes calibration applied " Bjarni Jonasson
2021-03-18 20:45 ` Andrew Lunn [this message]
2021-03-18 12:38 ` [PATCH net-next v1 3/3] net: phy: mscc: coma mode disabled for VSC8584 Bjarni Jonasson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFO7zN9iUMelyCdD@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=atenart@kernel.org \
--cc=bjarni.jonasson@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=quentin.schulz@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).