From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84A90C433F2 for ; Sun, 21 Mar 2021 08:35:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CA1361950 for ; Sun, 21 Mar 2021 08:35:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230084AbhCUI3L (ORCPT ); Sun, 21 Mar 2021 04:29:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:48902 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229784AbhCUI2x (ORCPT ); Sun, 21 Mar 2021 04:28:53 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2A04B6192F; Sun, 21 Mar 2021 08:28:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616315332; bh=Iv6go7i27JUrhyzVdDbwoLLwuIfA0usEsppHcbzNwjE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SBjjyp9+aGelAw2A/2iwUBbB/Ejw3pPWVlQ9bZZGzqnYr/bZWE+gte+VuM8+KmZtn JQ0ikq97mHEMy39gd7DmzpELb2c/3imOC2XhDdFtqe2HSMXvBuzv4MjmgTQ06KJHVA E/4wgaKKoJfhwd4MGBLlLRKoqy5agL5XRMYvEai2qTXk3iu4yIB4p/tBoSZRf23KdT vu85cZbdm+C2NsMqNoDvrRW9rznzsRgeUEkCOXvE6suIHJNu9nYkWVViyW+xAbigK/ 13fQICYthOJuACy4fbDp/FScfz35A4q4dohwthn6nQbBfkOoZ0q0emaSRSnuDk2WPU LSuiUs/QGZykg== Date: Sun, 21 Mar 2021 10:28:49 +0200 From: Leon Romanovsky To: Dmitry Vyukov Cc: davem@davemloft.net, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: make unregister netdev warning timeout configurable Message-ID: References: <20210320142851.1328291-1-dvyukov@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210320142851.1328291-1-dvyukov@google.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Mar 20, 2021 at 03:28:51PM +0100, Dmitry Vyukov wrote: > netdev_wait_allrefs() issues a warning if refcount does not drop to 0 > after 10 seconds. While 10 second wait generally should not happen > under normal workload in normal environment, it seems to fire falsely > very often during fuzzing and/or in qemu emulation (~10x slower). > At least it's not possible to understand if it's really a false > positive or not. Automated testing generally bumps all timeouts > to very high values to avoid flake failures. > Make the timeout configurable for automated testing systems. > Lowering the timeout may also be useful for e.g. manual bisection. > The default value matches the current behavior. > > Signed-off-by: Dmitry Vyukov > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=211877 > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > net/Kconfig | 12 ++++++++++++ > net/core/dev.c | 4 +++- > 2 files changed, 15 insertions(+), 1 deletion(-) > Our verification team would like to see this change too. Thanks, Reviewed-by: Leon Romanovsky