From: Leon Romanovsky <leon@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: netdev@vger.kernel.org, Karsten Keil <isdn@linux-pingi.de>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] [v2] misdn: avoid -Wempty-body warning
Date: Mon, 22 Mar 2021 15:58:30 +0200 [thread overview]
Message-ID: <YFiihvb1TLFaAZdH@unreal> (raw)
In-Reply-To: <20210322121453.653228-1-arnd@kernel.org>
On Mon, Mar 22, 2021 at 01:14:47PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> gcc warns about a pointless condition:
>
> drivers/isdn/hardware/mISDN/hfcmulti.c: In function 'hfcmulti_interrupt':
> drivers/isdn/hardware/mISDN/hfcmulti.c:2752:17: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 2752 | ; /* external IRQ */
>
> As the check has no effect, just remove it.
>
> Suggested-by: Leon Romanovsky <leon@kernel.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: remove the line instead of adding {}
> ---
> drivers/isdn/hardware/mISDN/hfcmulti.c | 2 --
> 1 file changed, 2 deletions(-)
>
Thanks, interesting when we will delete whole drivers/isdn :)
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2021-03-22 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 12:14 [PATCH net-next] [v2] misdn: avoid -Wempty-body warning Arnd Bergmann
2021-03-22 13:58 ` Leon Romanovsky [this message]
2021-03-22 14:37 ` Arnd Bergmann
2021-03-22 20:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFiihvb1TLFaAZdH@unreal \
--to=leon@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=isdn@linux-pingi.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).