From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Florian Westphal <fw@strlen.de>,
"David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>,
linux-stable <stable@vger.kernel.org>,
Mat Martineau <mathew.j.martineau@linux.intel.com>,
Sasha Levin <sashal@kernel.org>,
Anders Roxell <anders.roxell@linaro.org>,
lkft-triage@lists.linaro.org, Netdev <netdev@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 5.10 104/157] mptcp: put subflow sock on connect error
Date: Wed, 24 Mar 2021 10:26:15 +0100 [thread overview]
Message-ID: <YFsFt1+5do3d0iTH@kroah.com> (raw)
In-Reply-To: <CA+G9fYvRM+9DmGuKM0ErDnrYBOmZ6zzmMkrWevMJqOzhejWwZg@mail.gmail.com>
On Wed, Mar 24, 2021 at 02:02:06PM +0530, Naresh Kamboju wrote:
> On Mon, 22 Mar 2021 at 18:15, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > From: Florian Westphal <fw@strlen.de>
> >
> > [ Upstream commit f07157792c633b528de5fc1dbe2e4ea54f8e09d4 ]
> >
> > mptcp_add_pending_subflow() performs a sock_hold() on the subflow,
> > then adds the subflow to the join list.
> >
> > Without a sock_put the subflow sk won't be freed in case connect() fails.
> >
> > unreferenced object 0xffff88810c03b100 (size 3000):
> > [..]
> > sk_prot_alloc.isra.0+0x2f/0x110
> > sk_alloc+0x5d/0xc20
> > inet6_create+0x2b7/0xd30
> > __sock_create+0x17f/0x410
> > mptcp_subflow_create_socket+0xff/0x9c0
> > __mptcp_subflow_connect+0x1da/0xaf0
> > mptcp_pm_nl_work+0x6e0/0x1120
> > mptcp_worker+0x508/0x9a0
> >
> > Fixes: 5b950ff4331ddda ("mptcp: link MPC subflow into msk only after accept")
> > Signed-off-by: Florian Westphal <fw@strlen.de>
> > Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> > Signed-off-by: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Sasha Levin <sashal@kernel.org>
>
> I have reported the following warnings and kernel crash on 5.10.26-rc2 [1]
> The bisect reported that issue pointing out to this commit.
>
> commit 460916534896e6d4f80a37152e0948db33376873
> mptcp: put subflow sock on connect error
>
> This problem is specific to 5.10.26-rc2.
Thank you for tracking this down!
prev parent reply other threads:[~2021-03-24 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210322121933.746237845@linuxfoundation.org>
[not found] ` <20210322121937.071435221@linuxfoundation.org>
2021-03-24 8:32 ` [PATCH 5.10 104/157] mptcp: put subflow sock on connect error Naresh Kamboju
2021-03-24 9:04 ` Florian Westphal
2021-03-24 9:22 ` Greg Kroah-Hartman
2021-03-24 14:28 ` Sasha Levin
2021-03-24 9:26 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFsFt1+5do3d0iTH@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=naresh.kamboju@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).