From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C3BAC433DB for ; Wed, 24 Mar 2021 13:48:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA48A61A01 for ; Wed, 24 Mar 2021 13:48:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235638AbhCXNrz (ORCPT ); Wed, 24 Mar 2021 09:47:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:49614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235459AbhCXNri (ORCPT ); Wed, 24 Mar 2021 09:47:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 70C9761A01; Wed, 24 Mar 2021 13:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616593658; bh=hPtkX3/xhO/wMcHvFW3k+WU/tC3UTlM33aGBYnU044k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PCJRLb5ZMtXr2zs8Fqq1xj/SB5G4ps4QtFfpEq9xp1/U3H7YsfQUS4P1fnpnCDYel /vtdVNWnGSV1gUJSZ8K/YYcKN4m6RhKaUOz2dUUIxFB2stb7DpaY3XB685c8CKhYT1 macxf/6XCSP8DIF+WgcuoEg22CfhtpS7vON2MQiVUChq/lnAdo2d0tG94x27EbadNA vnsYp1+7Q51RuY1sh5jRnjrf2J38YqDxO+Ofin9d7hjIljSsdgADMgi0983v6cZTGz Vq/GrtvfgmzwVD6XCzrSECkGLoRk2KQG874PsQpaiUjWWEef10tGQU2Tc34ycjP/Y6 bD3meZen0Xa4Q== Date: Wed, 24 Mar 2021 15:47:34 +0200 From: Leon Romanovsky To: Shiraz Saleem Cc: dledford@redhat.com, jgg@nvidia.com, kuba@kernel.org, davem@davemloft.net, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, david.m.ertman@intel.com, anthony.l.nguyen@intel.com, Mustafa Ismail Subject: Re: [PATCH v2 08/23] RDMA/irdma: Register auxiliary driver and implement private channel OPs Message-ID: References: <20210324000007.1450-1-shiraz.saleem@intel.com> <20210324000007.1450-9-shiraz.saleem@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210324000007.1450-9-shiraz.saleem@intel.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Mar 23, 2021 at 06:59:52PM -0500, Shiraz Saleem wrote: > From: Mustafa Ismail > > Register auxiliary drivers which can attach to auxiliary RDMA > devices from Intel PCI netdev drivers i40e and ice. Implement the private > channel ops, and register net notifiers. > > Signed-off-by: Mustafa Ismail > Signed-off-by: Shiraz Saleem > --- > drivers/infiniband/hw/irdma/i40iw_if.c | 229 +++++++++++++ > drivers/infiniband/hw/irdma/main.c | 382 ++++++++++++++++++++++ > drivers/infiniband/hw/irdma/main.h | 565 +++++++++++++++++++++++++++++++++ > 3 files changed, 1176 insertions(+) > create mode 100644 drivers/infiniband/hw/irdma/i40iw_if.c > create mode 100644 drivers/infiniband/hw/irdma/main.c > create mode 100644 drivers/infiniband/hw/irdma/main.h <...> > +/* client interface functions */ > +static const struct i40e_client_ops i40e_ops = { > + .open = i40iw_open, > + .close = i40iw_close, > + .l2_param_change = i40iw_l2param_change > +}; > + > +static struct i40e_client i40iw_client = { > + .ops = &i40e_ops, > + .type = I40E_CLIENT_IWARP, > +}; > + > +static int i40iw_probe(struct auxiliary_device *aux_dev, const struct auxiliary_device_id *id) > +{ > + struct i40e_auxiliary_device *i40e_adev = container_of(aux_dev, > + struct i40e_auxiliary_device, > + aux_dev); > + struct i40e_info *cdev_info = i40e_adev->ldev; > + > + strncpy(i40iw_client.name, "irdma", I40E_CLIENT_STR_LENGTH); > + cdev_info->client = &i40iw_client; > + cdev_info->aux_dev = aux_dev; > + > + return cdev_info->ops->client_device_register(cdev_info); Why do we need all this indirection? I see it as leftover from previous version where you mixed auxdev with your peer registration logic. Thanks