From: Petko Manolov <petkan@nucleusys.com>
To: 'Qiheng Lin <linqiheng@huawei.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH net-next] net: usb: pegasus: Remove duplicated include from pegasus.c
Date: Thu, 25 Mar 2021 18:12:46 +0200 [thread overview]
Message-ID: <YFy2fnV7GQLOKkRy@carbon> (raw)
In-Reply-To: <20210325145652.13469-1-linqiheng@huawei.com>
On 21-03-25 22:56:52, 'Qiheng Lin wrote:
> From: Qiheng Lin <linqiheng@huawei.com>
>
> Remove duplicated include.
It is not duplicated so do not remove it. Go ahead and look carefully at the
code, please.
Petko
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
> ---
> drivers/net/usb/pegasus.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
> index 9a907182569c..e0ee5c096396 100644
> --- a/drivers/net/usb/pegasus.c
> +++ b/drivers/net/usb/pegasus.c
> @@ -65,7 +65,6 @@ static struct usb_eth_dev usb_dev_id[] = {
> {.name = pn, .vendor = vid, .device = pid, .private = flags},
> #define PEGASUS_DEV_CLASS(pn, vid, pid, dclass, flags) \
> PEGASUS_DEV(pn, vid, pid, flags)
> -#include "pegasus.h"
> #undef PEGASUS_DEV
> #undef PEGASUS_DEV_CLASS
> {NULL, 0, 0, 0},
> @@ -84,7 +83,6 @@ static struct usb_device_id pegasus_ids[] = {
> #define PEGASUS_DEV_CLASS(pn, vid, pid, dclass, flags) \
> {.match_flags = (USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_DEV_CLASS), \
> .idVendor = vid, .idProduct = pid, .bDeviceClass = dclass},
> -#include "pegasus.h"
> #undef PEGASUS_DEV
> #undef PEGASUS_DEV_CLASS
> {},
>
>
prev parent reply other threads:[~2021-03-25 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 14:56 [PATCH net-next] net: usb: pegasus: Remove duplicated include from pegasus.c 'Qiheng Lin
2021-03-25 15:11 ` Greg KH
2021-03-25 16:12 ` Petko Manolov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFy2fnV7GQLOKkRy@carbon \
--to=petkan@nucleusys.com \
--cc=davem@davemloft.net \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linqiheng@huawei.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).