* [PATCH net-next] net: usb: pegasus: Remove duplicated include from pegasus.c
@ 2021-03-25 14:56 'Qiheng Lin
2021-03-25 15:11 ` Greg KH
2021-03-25 16:12 ` Petko Manolov
0 siblings, 2 replies; 3+ messages in thread
From: 'Qiheng Lin @ 2021-03-25 14:56 UTC (permalink / raw)
To: linqiheng, Petko Manolov, David S. Miller, Jakub Kicinski
Cc: linux-usb, netdev, kernel-janitors, Hulk Robot
From: Qiheng Lin <linqiheng@huawei.com>
Remove duplicated include.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
---
drivers/net/usb/pegasus.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
index 9a907182569c..e0ee5c096396 100644
--- a/drivers/net/usb/pegasus.c
+++ b/drivers/net/usb/pegasus.c
@@ -65,7 +65,6 @@ static struct usb_eth_dev usb_dev_id[] = {
{.name = pn, .vendor = vid, .device = pid, .private = flags},
#define PEGASUS_DEV_CLASS(pn, vid, pid, dclass, flags) \
PEGASUS_DEV(pn, vid, pid, flags)
-#include "pegasus.h"
#undef PEGASUS_DEV
#undef PEGASUS_DEV_CLASS
{NULL, 0, 0, 0},
@@ -84,7 +83,6 @@ static struct usb_device_id pegasus_ids[] = {
#define PEGASUS_DEV_CLASS(pn, vid, pid, dclass, flags) \
{.match_flags = (USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_DEV_CLASS), \
.idVendor = vid, .idProduct = pid, .bDeviceClass = dclass},
-#include "pegasus.h"
#undef PEGASUS_DEV
#undef PEGASUS_DEV_CLASS
{},
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: usb: pegasus: Remove duplicated include from pegasus.c
2021-03-25 14:56 [PATCH net-next] net: usb: pegasus: Remove duplicated include from pegasus.c 'Qiheng Lin
@ 2021-03-25 15:11 ` Greg KH
2021-03-25 16:12 ` Petko Manolov
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2021-03-25 15:11 UTC (permalink / raw)
To: 'Qiheng Lin
Cc: Petko Manolov, David S. Miller, Jakub Kicinski, linux-usb, netdev,
kernel-janitors, Hulk Robot
On Thu, Mar 25, 2021 at 10:56:52PM +0800, 'Qiheng Lin wrote:
> From: Qiheng Lin <linqiheng@huawei.com>
>
> Remove duplicated include.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
> ---
> drivers/net/usb/pegasus.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
> index 9a907182569c..e0ee5c096396 100644
> --- a/drivers/net/usb/pegasus.c
> +++ b/drivers/net/usb/pegasus.c
> @@ -65,7 +65,6 @@ static struct usb_eth_dev usb_dev_id[] = {
> {.name = pn, .vendor = vid, .device = pid, .private = flags},
> #define PEGASUS_DEV_CLASS(pn, vid, pid, dclass, flags) \
> PEGASUS_DEV(pn, vid, pid, flags)
> -#include "pegasus.h"
> #undef PEGASUS_DEV
> #undef PEGASUS_DEV_CLASS
> {NULL, 0, 0, 0},
> @@ -84,7 +83,6 @@ static struct usb_device_id pegasus_ids[] = {
> #define PEGASUS_DEV_CLASS(pn, vid, pid, dclass, flags) \
> {.match_flags = (USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_DEV_CLASS), \
> .idVendor = vid, .idProduct = pid, .bDeviceClass = dclass},
> -#include "pegasus.h"
> #undef PEGASUS_DEV
> #undef PEGASUS_DEV_CLASS
> {},
>
Did you build and test this code now with this change?
I think you broke this driver badly now :(
Please think about _why_ the code would have been written this way in
the first place, it is a bit odd, right?
netdev maintainers, consider this a NAK.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: usb: pegasus: Remove duplicated include from pegasus.c
2021-03-25 14:56 [PATCH net-next] net: usb: pegasus: Remove duplicated include from pegasus.c 'Qiheng Lin
2021-03-25 15:11 ` Greg KH
@ 2021-03-25 16:12 ` Petko Manolov
1 sibling, 0 replies; 3+ messages in thread
From: Petko Manolov @ 2021-03-25 16:12 UTC (permalink / raw)
To: 'Qiheng Lin
Cc: David S. Miller, Jakub Kicinski, linux-usb, netdev,
kernel-janitors, Hulk Robot
On 21-03-25 22:56:52, 'Qiheng Lin wrote:
> From: Qiheng Lin <linqiheng@huawei.com>
>
> Remove duplicated include.
It is not duplicated so do not remove it. Go ahead and look carefully at the
code, please.
Petko
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
> ---
> drivers/net/usb/pegasus.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c
> index 9a907182569c..e0ee5c096396 100644
> --- a/drivers/net/usb/pegasus.c
> +++ b/drivers/net/usb/pegasus.c
> @@ -65,7 +65,6 @@ static struct usb_eth_dev usb_dev_id[] = {
> {.name = pn, .vendor = vid, .device = pid, .private = flags},
> #define PEGASUS_DEV_CLASS(pn, vid, pid, dclass, flags) \
> PEGASUS_DEV(pn, vid, pid, flags)
> -#include "pegasus.h"
> #undef PEGASUS_DEV
> #undef PEGASUS_DEV_CLASS
> {NULL, 0, 0, 0},
> @@ -84,7 +83,6 @@ static struct usb_device_id pegasus_ids[] = {
> #define PEGASUS_DEV_CLASS(pn, vid, pid, dclass, flags) \
> {.match_flags = (USB_DEVICE_ID_MATCH_DEVICE | USB_DEVICE_ID_MATCH_DEV_CLASS), \
> .idVendor = vid, .idProduct = pid, .bDeviceClass = dclass},
> -#include "pegasus.h"
> #undef PEGASUS_DEV
> #undef PEGASUS_DEV_CLASS
> {},
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-25 16:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-25 14:56 [PATCH net-next] net: usb: pegasus: Remove duplicated include from pegasus.c 'Qiheng Lin
2021-03-25 15:11 ` Greg KH
2021-03-25 16:12 ` Petko Manolov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).