From: Andrew Lunn <andrew@lunn.ch>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Dexuan Cui <decui@microsoft.com>,
davem@davemloft.net, kuba@kernel.org, kys@microsoft.com,
haiyangz@microsoft.com, sthemmin@microsoft.com,
wei.liu@kernel.org, liuwe@microsoft.com, netdev@vger.kernel.org,
leon@kernel.org, bernd@petrovitsch.priv.at,
rdunlap@infradead.org, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org
Subject: Re: [PATCH v3 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA)
Date: Fri, 9 Apr 2021 02:30:12 +0200 [thread overview]
Message-ID: <YG+gFMnVuvtlHNQQ@lunn.ch> (raw)
In-Reply-To: <20210408164552.2d67f7b1@hermes.local>
> Linux kernel doesn't do namespaces in the code, so every new driver needs
> to worry about global symbols clashing
This driver is called mana, yet the code uses ana. It would be good to
resolve this inconsistency as well. Ideally, you want to prefix
everything with ana_ or mana_, depending on what you choose, so we
have a clean namespace.
Andrew
next prev parent reply other threads:[~2021-04-09 0:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 22:58 [PATCH v3 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA) Dexuan Cui
2021-04-08 23:45 ` Stephen Hemminger
2021-04-09 0:30 ` Andrew Lunn [this message]
2021-04-09 0:54 ` Dexuan Cui
2021-04-08 23:46 ` David Miller
2021-04-09 0:24 ` Dexuan Cui
2021-04-09 0:41 ` David Miller
2021-04-09 0:47 ` Dexuan Cui
2021-04-09 3:58 ` Haiyang Zhang
2021-04-09 13:35 ` Andrew Lunn
2021-04-08 23:51 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG+gFMnVuvtlHNQQ@lunn.ch \
--to=andrew@lunn.ch \
--cc=bernd@petrovitsch.priv.at \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuwe@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox