From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81920C433E0 for ; Mon, 29 Mar 2021 18:56:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B4C061976 for ; Mon, 29 Mar 2021 18:56:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230506AbhC2S4Q (ORCPT ); Mon, 29 Mar 2021 14:56:16 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:53156 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231237AbhC2Szu (ORCPT ); Mon, 29 Mar 2021 14:55:50 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lQx2p-00Drfi-AO; Mon, 29 Mar 2021 20:55:23 +0200 Date: Mon, 29 Mar 2021 20:55:23 +0200 From: Andrew Lunn To: Steen Hegelund Cc: Kishon Vijay Abraham I , Vinod Koul , linux-arm-kernel@lists.infradead.org, Alexandre Belloni , Microchip UNG Driver List , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH linux-next 1/1] phy: Sparx5 Eth SerDes: Use direct register operations Message-ID: References: <20210329081438.558885-1-steen.hegelund@microchip.com> <20210329081438.558885-2-steen.hegelund@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210329081438.558885-2-steen.hegelund@microchip.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 29, 2021 at 10:14:38AM +0200, Steen Hegelund wrote: > Use direct register operations instead of a table of register > information to lower the stack usage. > > Signed-off-by: Steen Hegelund > Reported-by: kernel test robot > --- > drivers/phy/microchip/sparx5_serdes.c | 1869 +++++++++++++------------ > 1 file changed, 951 insertions(+), 918 deletions(-) > > diff --git a/drivers/phy/microchip/sparx5_serdes.c b/drivers/phy/microchip/sparx5_serdes.c > index 06bcf0c166cf..43de68a62c2f 100644 > --- a/drivers/phy/microchip/sparx5_serdes.c > +++ b/drivers/phy/microchip/sparx5_serdes.c > @@ -343,12 +343,6 @@ struct sparx5_sd10g28_params { > u8 fx_100; > }; > > -struct sparx5_serdes_regval { > - u32 value; > - u32 mask; > - void __iomem *addr; > -}; > - > static struct sparx5_sd25g28_media_preset media_presets_25g[] = { > { /* ETH_MEDIA_DEFAULT */ > .cfg_en_adv = 0, > @@ -945,431 +939,411 @@ static void sparx5_sd25g28_reset(void __iomem *regs[], > } > } > > -static int sparx5_sd25g28_apply_params(struct device *dev, > - void __iomem *regs[], > - struct sparx5_sd25g28_params *params, > - u32 sd_index) > +static int sparx5_sd25g28_apply_params(struct sparx5_serdes_macro *macro, > + struct sparx5_sd25g28_params *params) > { > - struct sparx5_serdes_regval item[] = { Could you just add const here, and then it is no longer on the stack? Andrew