From: Andrew Lunn <andrew@lunn.ch>
To: Grant Grundler <grundler@chromium.org>
Cc: Oliver Neukum <oneukum@suse.com>,
Jakub Kicinski <kuba@kernel.org>,
Roland Dreier <roland@kernel.org>,
nic_swsd <nic_swsd@realtek.com>, netdev <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv4 3/4] net: cdc_ncm: record speed in status method
Date: Thu, 1 Apr 2021 00:42:27 +0200 [thread overview]
Message-ID: <YGT60zQuo1XW85wb@lunn.ch> (raw)
In-Reply-To: <20210330021651.30906-4-grundler@chromium.org>
On Mon, Mar 29, 2021 at 07:16:50PM -0700, Grant Grundler wrote:
> From: Oliver Neukum <oneukum@suse.com>
>
> Until very recently, the usbnet framework only had support functions
> for devices which reported the link speed by explicitly querying the
> PHY over a MDIO interface. However, the cdc_ncm devices send
> notifications when the link state or link speeds change and do not
> expose the PHY (or modem) directly.
>
> Support funtions (e.g. usbnet_get_link_ksettings_internal()) to directly
> query state recorded by the cdc_ncm driver were added in a previous patch.
>
> So instead of cdc_ncm spewing the link speed into the dmesg buffer,
> record the link speed encoded in these notifications and tell the
> usbnet framework to use the new functions to get link speed/state.
> Link speed/state is now available via ethtool.
>
> This is especially useful given all current RTL8156 devices emit
> a connection/speed status notification every 32ms and this would
> fill the dmesg buffer. This implementation replaces the one
> recently submitted in de658a195ee23ca6aaffe197d1d2ea040beea0a2 :
> "net: usb: cdc_ncm: don't spew notifications"
>
> v2: rebased on upstream
> v3: changed variable names
> v4: rewrote commit message
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Tested-by: Roland Dreier <roland@kernel.org>
> Signed-off-by: Grant Grundler <grundler@chromium.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2021-03-31 22:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 2:16 [PATCHv4 0/4] usbnet: speed reporting for devices without MDIO Grant Grundler
2021-03-30 2:16 ` [PATCHv4 1/4] usbnet: add _mii suffix to usbnet_set/get_link_ksettings Grant Grundler
2021-03-31 22:40 ` Andrew Lunn
2021-03-30 2:16 ` [PATCHv4 2/4] usbnet: add method for reporting speed without MII Grant Grundler
2021-03-31 22:41 ` Andrew Lunn
2021-03-30 2:16 ` [PATCHv4 3/4] net: cdc_ncm: record speed in status method Grant Grundler
2021-03-31 22:42 ` Andrew Lunn [this message]
2021-03-30 2:16 ` [PATCHv4 4/4] net: cdc_ether: " Grant Grundler
2021-03-31 22:43 ` Andrew Lunn
2021-04-05 23:16 ` [PATCHv4 0/4] usbnet: speed reporting for devices without MDIO Grant Grundler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGT60zQuo1XW85wb@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=grundler@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=oneukum@suse.com \
--cc=roland@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).