From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09216C433ED for ; Wed, 31 Mar 2021 22:42:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD1E0610A1 for ; Wed, 31 Mar 2021 22:42:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232565AbhCaWmC (ORCPT ); Wed, 31 Mar 2021 18:42:02 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:57138 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbhCaWld (ORCPT ); Wed, 31 Mar 2021 18:41:33 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lRjWe-00EFD7-3l; Thu, 01 Apr 2021 00:41:24 +0200 Date: Thu, 1 Apr 2021 00:41:24 +0200 From: Andrew Lunn To: Grant Grundler Cc: Oliver Neukum , Jakub Kicinski , Roland Dreier , nic_swsd , netdev , "David S . Miller" , LKML Subject: Re: [PATCHv4 2/4] usbnet: add method for reporting speed without MII Message-ID: References: <20210330021651.30906-1-grundler@chromium.org> <20210330021651.30906-3-grundler@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330021651.30906-3-grundler@chromium.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Mar 29, 2021 at 07:16:49PM -0700, Grant Grundler wrote: > From: Oliver Neukum > > The old method for reporting link speed assumed a driver uses the > generic phy (mii) MDIO read/write functions. CDC devices don't > expose the phy. > > Add a primitive internal version reporting back directly what > the CDC notification/status operations recorded. > > v2: rebased on upstream > v3: changed names and made clear which units are used > v4: moved hunks to correct patch; rewrote commmit messages > > Signed-off-by: Oliver Neukum > Tested-by: Roland Dreier > Reviewed-by: Grant Grundler > Tested-by: Grant Grundler Reviewed-by: Andrew Lunn Andrew