From: Hongren Zheng <i@zenithal.me>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] iptoken: Add doc on the conditions of iptoken
Date: Thu, 1 Apr 2021 18:41:18 +0800 [thread overview]
Message-ID: <YGWjTg2yzYT3V7YN@Sun> (raw)
In-Reply-To: <20210331152602.50cc4a79@hermes.local>
On Wed, Mar 31, 2021 at 03:26:02PM -0700, Stephen Hemminger wrote:
> It would be better if kernel provided the error messages through external ack
> of the netlink message,
Agreed.
> rather than providing potentially out of date
> recommendations on the man page.
I still think conditions for ip-token to be accepted and take
effect should be documented on the man page.
Errors in kernel extack only give hints to users in case they
forget to configure some flags. For new users, a complete
condition reference should be documented for them to
evaluate the use case of ip-token.
Also the autoconf flag would not prompt errors when the user
forgets to turn it on, this is unexpected when the user does
intend to use ip-token.
Even /proc/sys interface may be out of date, these conditions
may remain unchanged or only be altered slightly, hence
documenting them does not hurt.
next prev parent reply other threads:[~2021-04-01 10:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 13:36 [PATCH iproute2] iptoken: Add doc on the conditions of iptoken Hongren Zheng
2021-03-31 22:26 ` Stephen Hemminger
2021-04-01 10:41 ` Hongren Zheng [this message]
2021-04-01 3:49 ` [RFC] add extack errors for iptoken Stephen Hemminger
2021-04-01 10:21 ` Hongren Zheng
2021-04-01 14:31 ` David Ahern
2021-04-01 15:06 ` Stephen Hemminger
2021-04-28 12:55 ` Hongren Zheng
2021-04-28 15:32 ` David Ahern
2021-05-29 6:31 ` Hongren Zheng
2021-05-31 2:42 ` Stephen Hemminger
2021-05-31 5:26 ` Hongren Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGWjTg2yzYT3V7YN@Sun \
--to=i@zenithal.me \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).