From: Andrew Lunn <andrew@lunn.ch>
To: Ioana Ciornei <ciorneiioana@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
ruxandra.radulescu@nxp.com, Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: [PATCH net-next v2 2/3] dpaa2-eth: add rx copybreak support
Date: Fri, 2 Apr 2021 14:36:33 +0200 [thread overview]
Message-ID: <YGcP0Uz5CfCwv5ev@lunn.ch> (raw)
In-Reply-To: <20210402095532.925929-3-ciorneiioana@gmail.com>
On Fri, Apr 02, 2021 at 12:55:31PM +0300, Ioana Ciornei wrote:
> From: Ioana Ciornei <ioana.ciornei@nxp.com>
>
> DMA unmapping, allocating a new buffer and DMA mapping it back on the
> refill path is really not that efficient. Proper buffer recycling (page
> pool, flipping the page and using the other half) cannot be done for
> DPAA2 since it's not a ring based controller but it rather deals with
> multiple queues which all get their buffers from the same buffer pool on
> Rx.
>
> To circumvent these limitations, add support for Rx copybreak. For small
> sized packets instead of creating a skb around the buffer in which the
> frame was received, allocate a new sk buffer altogether, copy the
> contents of the frame and release the initial page back into the buffer
> pool.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2021-04-02 12:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 9:55 [PATCH net-next v2 0/3] dpaa2-eth: add rx copybreak support Ioana Ciornei
2021-04-02 9:55 ` [PATCH net-next v2 1/3] dpaa2-eth: rename dpaa2_eth_xdp_release_buf into dpaa2_eth_recycle_buf Ioana Ciornei
2021-04-02 9:55 ` [PATCH net-next v2 2/3] dpaa2-eth: add rx copybreak support Ioana Ciornei
2021-04-02 12:36 ` Andrew Lunn [this message]
2021-04-02 9:55 ` [PATCH net-next v2 3/3] dpaa2-eth: export the rx copybreak value as an ethtool tunable Ioana Ciornei
2021-04-02 21:30 ` [PATCH net-next v2 0/3] dpaa2-eth: add rx copybreak support patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGcP0Uz5CfCwv5ev@lunn.ch \
--to=andrew@lunn.ch \
--cc=ciorneiioana@gmail.com \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).