From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67CC5C433B4 for ; Mon, 19 Apr 2021 20:54:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3843461104 for ; Mon, 19 Apr 2021 20:54:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243205AbhDSUyF (ORCPT ); Mon, 19 Apr 2021 16:54:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43688 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243545AbhDSUwm (ORCPT ); Mon, 19 Apr 2021 16:52:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618865532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vIlLaTW2HU8DsnJAEsVpsAdmhbeVPpHFEcppC+CVot4=; b=FeOdIuK7DR3l/K6eZj/BgZTeKTAlaV3pFfGQn7nvQQWgsSetFF9gq1yDnN5Qla3YH7HXc/ AZ6CPdolSAO5xTc5QIDSoVzuLz9sNbLONAT3cTXLZpdne2fOLp5JJeY8N2bac/d1JWYf4V 2O9EL3VIy0PhvyUsAzNmGITNQWSbkWQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-161-yVwC0uY_O-WiFFu19q4LZg-1; Mon, 19 Apr 2021 16:52:10 -0400 X-MC-Unique: yVwC0uY_O-WiFFu19q4LZg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3B06F107ACC7; Mon, 19 Apr 2021 20:51:51 +0000 (UTC) Received: from krava (unknown [10.40.195.124]) by smtp.corp.redhat.com (Postfix) with SMTP id 99F655D74B; Mon, 19 Apr 2021 20:51:47 +0000 (UTC) Date: Mon, 19 Apr 2021 22:51:46 +0200 From: Jiri Olsa To: Steven Rostedt Cc: Andrii Nakryiko , Jiri Olsa , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Networking , bpf , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Daniel Xu , Jesper Brouer , Toke =?iso-8859-1?Q?H=F8iland-J=F8rgensen?= , Viktor Malik Subject: Re: [PATCHv2 RFC bpf-next 0/7] bpf: Add support for ftrace probe Message-ID: References: <20210413121516.1467989-1-jolsa@kernel.org> <20210415111002.324b6bfa@gandalf.local.home> <20210415141831.7b8fbe72@gandalf.local.home> <20210415142120.7427b4bd@gandalf.local.home> <20210415193032.34aec994@oasis.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210415193032.34aec994@oasis.local.home> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 15, 2021 at 07:30:32PM -0400, Steven Rostedt wrote: > On Thu, 15 Apr 2021 23:49:43 +0200 > Jiri Olsa wrote: > > > > right, I quickly checked on that and it looks exactly like > > the thing we need > > > > I'll try to rebase that on the current code and try to use > > it with the bpf ftrace probe to see how it fits > > > > any chance you could plan on reposting it? ;-) > > I'm currently working on cleaning up code for the next merge window, > but I did go ahead and rebase it on top of my for-next branch. I didn't > event try to compile it, but at least it's rebased ;-) > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git > > Branch: ftrace/fgraph-multi works nicely (with small compilation fixes) I added support to call bpf program on the function exit using fgraph_ops and it seems to work now, it looks like the fgraph_ops entry callback does not have access to registers.. once we have that, we could store arguments for the exit callback and have all in place.. could this be added? ;-) thanks, jirka