From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF5C9C433B4 for ; Fri, 16 Apr 2021 19:21:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9147F6137D for ; Fri, 16 Apr 2021 19:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238465AbhDPTVr (ORCPT ); Fri, 16 Apr 2021 15:21:47 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:59021 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239770AbhDPTVo (ORCPT ); Fri, 16 Apr 2021 15:21:44 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C1A385C01FA; Fri, 16 Apr 2021 15:21:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 16 Apr 2021 15:21:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=hkuUGq h9yWA89x/h1qAfVGkW6sekiVlt/+V74/O8dKM=; b=N/u8ATg6im9EYVGjvc3Hcq vkQwfJFx3B0Jc8318uEtqYV6YtkjRIiG5f37pKMnpn+4z/S70JDXR7UNEJjMfiye tch+h+mEsy266hrnAnaAfH9Aft0PAl1MpbpX+lawLSuroYONKQ42mhhliV9LD+Uo dVH/Z7/zXjlV5Yiy6BsC4XTe1V6JkLdvrrgjHRk6QKTGDI8zbDvrUxEI0CyiynHh JQ/IlK6DDhs9lcTQlGXq1jfukljSpLcV9m7umaeUmCE3SguOJKEApdNqFBijOoiN k0PBN6IRUoWqDGZEl782zRrS1Z5a/FrN/E3HJexaEgMqtvqZkiKAgkU/qBAGmN0w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelhedgudeflecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttd ortddttddvnecuhfhrohhmpefkughoucfutghhihhmmhgvlhcuoehiughoshgthhesihgu ohhstghhrdhorhhgqeenucggtffrrghtthgvrhhnpefgjeevhfdvgeeiudekteduveegue ejfefffeefteekkeeuueehjeduledtjeeuudenucfkphepkeegrddvvdelrdduheefrddu keejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: from localhost (igld-84-229-153-187.inter.net.il [84.229.153.187]) by mail.messagingengine.com (Postfix) with ESMTPA id ACAD2240057; Fri, 16 Apr 2021 15:21:16 -0400 (EDT) Date: Fri, 16 Apr 2021 22:21:12 +0300 From: Ido Schimmel To: Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, andrew@lunn.ch, mkubecek@suse.cz, idosch@nvidia.com, saeedm@nvidia.com, michael.chan@broadcom.com Subject: Re: [PATCH net-next 7/9] mlxsw: implement ethtool standard stats Message-ID: References: <20210416022752.2814621-1-kuba@kernel.org> <20210416022752.2814621-8-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416022752.2814621-8-kuba@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 15, 2021 at 07:27:50PM -0700, Jakub Kicinski wrote: > mlxsw has nicely grouped stats, add support for standard uAPI. > I'm guessing the register access part. Compile tested only. Jakub, wanted to let you know that it seems to be working. I'll review the patches tomorrow/Sunday, as it's already late here. Thanks! $ ./ethtool -S swp13 --groups eth-phy eth-mac rmon Standard stats for swp13: eth-phy-SymbolErrorDuringCarrier: 0 eth-mac-FramesTransmittedOK: 8 eth-mac-FramesReceivedOK: 8 eth-mac-FrameCheckSequenceErrors: 0 eth-mac-AlignmentErrors: 0 eth-mac-OctetsTransmittedOK: 928 eth-mac-OctetsReceivedOK: 848 eth-mac-MulticastFramesXmittedOK: 8 eth-mac-BroadcastFramesXmittedOK: 0 eth-mac-MulticastFramesReceivedOK: 8 eth-mac-BroadcastFramesReceivedOK: 0 eth-mac-InRangeLengthErrors: 0 eth-mac-OutOfRangeLengthField: 0 eth-mac-FrameTooLongErrors: 0 rmon-etherStatsUndersizePkts: 0 rmon-etherStatsOversizePkts: 0 rmon-etherStatsFragments: 0 rmon-rx-etherStatsPkts64Octets: 0 rmon-rx-etherStatsPkts65to127Octets: 6 rmon-rx-etherStatsPkts128to255Octets: 2 rmon-rx-etherStatsPkts256to511Octets: 0 rmon-rx-etherStatsPkts512to1023Octets: 0 rmon-rx-etherStatsPkts1024to1518Octets: 0 rmon-rx-etherStatsPkts1519to2047Octets: 0 rmon-rx-etherStatsPkts2048to4095Octets: 0 rmon-rx-etherStatsPkts4096to8191Octets: 0 rmon-rx-etherStatsPkts8192to10239Octets: 0