From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896A6C433ED for ; Fri, 16 Apr 2021 21:29:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AD3D613D2 for ; Fri, 16 Apr 2021 21:29:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245341AbhDPV37 (ORCPT ); Fri, 16 Apr 2021 17:29:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40421 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235451AbhDPV36 (ORCPT ); Fri, 16 Apr 2021 17:29:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618608573; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XeO4BER1G31a5T0rppP5pwUd7m/pGl6W9xONhQxZ6VY=; b=LMkl63l6ruIXD8cJREMeiRlAQNeU635/QraC3LOpc2TFl0Y2jd1HD6QZjJ0kj9ZmckVmYQ PDossQ/XM21/T2+O5U2+FAqr9+lwKWCbmSXE+PWuURVc4AJQV6Em12F42sBj9xQkWCNnfL 49D8aZQMniCQGFXkOkqcLMAG2O853ek= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-333-rpCXrD5IN2eDXzd1nvbvYA-1; Fri, 16 Apr 2021 17:29:31 -0400 X-MC-Unique: rpCXrD5IN2eDXzd1nvbvYA-1 Received: by mail-ed1-f71.google.com with SMTP id o4-20020a0564024384b0290378d45ecf57so7734174edc.12 for ; Fri, 16 Apr 2021 14:29:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XeO4BER1G31a5T0rppP5pwUd7m/pGl6W9xONhQxZ6VY=; b=NmyvnLA70oAdFVNkFjVZT4y+iTtmbqgtMxu3amKpCP6V9EpWcPGNWa6em6MbXgsuFR zojJH3xGObSyDpHbNnjA/UppcWMWOsIS4eMLjK9+LbidZdzzKRHK9Rq7qm9X8Ys8i0l/ ODHU8RIy+JEi4m5JVuGiXSO6Lll5vq8UK5G5KbNMABd1Il26Ffi5z1xc63rMbExd6QPy qnJX1WWtHo7vBT4yCYxLOyvsvMb6DbHYZqLsF3tk6BRbd4YNi2Lmm8srhhGktQFP00bY hWCyJM4X+xqviS1Qgwfo/zLbtjMepRqcqX55esItlAv5XaThKUpfbTIulyNSU9z+jnFj XuPA== X-Gm-Message-State: AOAM532DmP4psV0eKGXlYa2GNHxzJvu4GO4Osw3z+SDfmyTNQ5qUMXwF WVSAFSwU+UKF0ttw1l4DBaRXIbcVD/U7sHEOmBzwqEG9BLAReqxsNwgkDoQzZa9EFcypqWvpkx+ 8fG45mOspQb2YfByh X-Received: by 2002:a05:6402:27ca:: with SMTP id c10mr11941216ede.382.1618608570315; Fri, 16 Apr 2021 14:29:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1vh+WAMfqnk3rkHgBWL2/nWXCYYBG9W7LGpiEfYSi2E3lKl3y6tqGMvx2ahkgLp9j6kNCgw== X-Received: by 2002:a05:6402:27ca:: with SMTP id c10mr11941206ede.382.1618608570177; Fri, 16 Apr 2021 14:29:30 -0700 (PDT) Received: from localhost ([151.66.28.185]) by smtp.gmail.com with ESMTPSA id l1sm6513150edt.59.2021.04.16.14.29.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Apr 2021 14:29:29 -0700 (PDT) Date: Fri, 16 Apr 2021 23:29:26 +0200 From: Lorenzo Bianconi To: Magnus Karlsson Cc: Lorenzo Bianconi , bpf , Network Development , "David S. Miller" , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , shayagr@amazon.com, sameehj@amazon.com, John Fastabend , David Ahern , Jesper Dangaard Brouer , Eelco Chaudron , Jason Wang , Alexander Duyck , Saeed Mahameed , "Fijalkowski, Maciej" , Tirthendu Subject: Re: [PATCH v8 bpf-next 00/14] mvneta: introduce XDP multi-buffer support Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6j9e9qg2MrHVlirf" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --6j9e9qg2MrHVlirf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable >=20 > Took your patches for a test run with the AF_XDP sample xdpsock on an > i40e card and the throughput degradation is between 2 to 6% depending > on the setup and microbenchmark within xdpsock that is executed. And > this is without sending any multi frame packets. Just single frame > ones. Tirtha made changes to the i40e driver to support this new > interface so that is being included in the measurements. Hi Magnus, thx for working on it. Assuming the fragmented part is only initialized/acc= essed if mb is set (so for multi frame packets), I would not expect any throughput degradation in the single frame scenario. Can you please share the i40e support added by Tirtha? >=20 > What performance do you see with the mvneta card? How much are we > willing to pay for this feature when it is not being used or can we in > some way selectively turn it on only when needed? IIRC I did not get sensible throughput degradation on mvneta but I will re-= run the tests running an updated bpf-next tree. Regards, Lorenzo >=20 > Thanks: Magnus >=20 > > Eelco Chaudron (4): > > bpf: add multi-buff support to the bpf_xdp_adjust_tail() API > > bpd: add multi-buffer support to xdp copy helpers > > bpf: add new frame_length field to the XDP ctx > > bpf: update xdp_adjust_tail selftest to include multi-buffer > > > > Lorenzo Bianconi (10): > > xdp: introduce mb in xdp_buff/xdp_frame > > xdp: add xdp_shared_info data structure > > net: mvneta: update mb bit before passing the xdp buffer to eBPF layer > > xdp: add multi-buff support to xdp_return_{buff/frame} > > net: mvneta: add multi buffer support to XDP_TX > > net: mvneta: enable jumbo frames for XDP > > net: xdp: add multi-buff support to xdp_build_skb_from_fram > > bpf: move user_size out of bpf_test_init > > bpf: introduce multibuff support to bpf_prog_test_run_xdp() > > bpf: test_run: add xdp_shared_info pointer in bpf_test_finish > > signature > > > > drivers/net/ethernet/marvell/mvneta.c | 182 ++++++++++-------- > > include/linux/filter.h | 7 + > > include/net/xdp.h | 105 +++++++++- > > include/uapi/linux/bpf.h | 1 + > > net/bpf/test_run.c | 109 +++++++++-- > > net/core/filter.c | 134 ++++++++++++- > > net/core/xdp.c | 103 +++++++++- > > tools/include/uapi/linux/bpf.h | 1 + > > .../bpf/prog_tests/xdp_adjust_tail.c | 105 ++++++++++ > > .../selftests/bpf/prog_tests/xdp_bpf2bpf.c | 127 ++++++++---- > > .../bpf/progs/test_xdp_adjust_tail_grow.c | 17 +- > > .../bpf/progs/test_xdp_adjust_tail_shrink.c | 32 ++- > > .../selftests/bpf/progs/test_xdp_bpf2bpf.c | 3 +- > > 13 files changed, 767 insertions(+), 159 deletions(-) > > > > -- > > 2.30.2 > > >=20 --6j9e9qg2MrHVlirf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCYHoBswAKCRA6cBh0uS2t rHN1AQD2U5dTQY+vrjWhNC2+YD/9ExF6p88dNDXyiLH5OCu6nQD/YtpEwgVSu9Mu beXla4CsKvRxRCIQ2gtk8jj/7+OtdQk= =L6FN -----END PGP SIGNATURE----- --6j9e9qg2MrHVlirf--