From: Ido Schimmel <idosch@idosch.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, andrew@lunn.ch,
mkubecek@suse.cz, idosch@nvidia.com, saeedm@nvidia.com,
michael.chan@broadcom.com
Subject: Re: [PATCH net-next 0/9] ethtool: add uAPI for reading standard stats
Date: Sun, 18 Apr 2021 11:24:17 +0300 [thread overview]
Message-ID: <YHvssTvheST9nE6d@shredder> (raw)
In-Reply-To: <20210416090816.3f805b96@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, Apr 16, 2021 at 09:08:16AM -0700, Jakub Kicinski wrote:
> On Fri, 16 Apr 2021 18:44:26 +0300 Ido Schimmel wrote:
> > Given that you have now standardized these stats, do you plan to feed
> > them into some monitoring system?
>
> Yes and no, I'm only intending to replace the internal FB ethtool
> scraping script with these stats..
Cool
>
> > For example, Prometheus has an ethtool
> > exporter [1] and now I see that support is also being added to
> > node_exporter [2] where it really belongs. They obviously mentioned [3]
> > the problem with lack of standardization: "There is also almost no
> > standardization, so if you use multiple network card vendors, you have
> > to examine the data closely to find out what is useful to you and set up
> > your alerts and dashboards accordingly."
> >
> > [1] https://github.com/Showmax/prometheus-ethtool-exporter
> > [2] https://github.com/prometheus/node_exporter/pull/1832
> > [3] https://tech.showmax.com/2018/11/scraping-ethtool-data-into-prometheus/
>
> Wow, are you working with those projects? We should probably let them
> know about the patches.
I'm mostly a user, not a contributor (wrote some exporters of my own).
I'll drop a comment there once your patches are in net-next.
prev parent reply other threads:[~2021-04-18 8:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 2:27 [PATCH net-next 0/9] ethtool: add uAPI for reading standard stats Jakub Kicinski
2021-04-16 2:27 ` [PATCH net-next 1/9] docs: networking: extend the statistics documentation Jakub Kicinski
2021-04-16 2:27 ` [PATCH net-next 2/9] docs: ethtool: document standard statistics Jakub Kicinski
2021-04-16 2:27 ` [PATCH net-next 3/9] ethtool: add a new command for reading standard stats Jakub Kicinski
2021-04-16 2:27 ` [PATCH net-next 4/9] ethtool: add interface to read standard MAC stats Jakub Kicinski
2021-04-16 2:27 ` [PATCH net-next 5/9] ethtool: add interface to read standard MAC Ctrl stats Jakub Kicinski
2021-04-16 2:27 ` [PATCH net-next 6/9] ethtool: add interface to read RMON stats Jakub Kicinski
2021-04-16 2:27 ` [PATCH net-next 7/9] mlxsw: implement ethtool standard stats Jakub Kicinski
2021-04-16 19:21 ` Ido Schimmel
2021-04-16 19:24 ` Jakub Kicinski
2021-04-16 2:27 ` [PATCH net-next 8/9] bnxt: " Jakub Kicinski
2021-04-16 2:27 ` [PATCH net-next 9/9] mlx5: " Jakub Kicinski
2021-04-16 15:44 ` [PATCH net-next 0/9] ethtool: add uAPI for reading " Ido Schimmel
2021-04-16 16:08 ` Jakub Kicinski
2021-04-18 8:24 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHvssTvheST9nE6d@shredder \
--to=idosch@idosch.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).