From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
"David S. Miller" <dddavem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Yevgeny Kliteynik <kliteyn@nvidia.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net/mlx5: net/mlx5: Fix some error messages
Date: Sun, 2 May 2021 10:41:59 +0300 [thread overview]
Message-ID: <YI5Xxw9R4DqEQ1uv@unreal> (raw)
In-Reply-To: <YIqTHAq37U57ehAa@mwanda>
On Thu, Apr 29, 2021 at 02:06:04PM +0300, Dan Carpenter wrote:
> This code was using IS_ERR() instead of PTR_ERR() so it prints 1 instead
> of the correct error code. Even better would be to use %pe which prints
> out the name of the error, as in "ENOMEM", "EINVAL" etc.
>
> Fixes: 25cb31768042 ("net/mlx5: E-Switch, Improve error messages in term table creation")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Use %pe instead of %ld.
>
> Leon says this goes through netdev instead of the RDMA tree.
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
prev parent reply other threads:[~2021-05-02 7:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 11:06 [PATCH v2 net-next] net/mlx5: net/mlx5: Fix some error messages Dan Carpenter
2021-05-02 7:41 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YI5Xxw9R4DqEQ1uv@unreal \
--to=leon@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=dddavem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kliteyn@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).