* [PATCH net-next] stmmac: intel: unlock on error path in intel_crosststamp()
@ 2021-04-21 13:22 Dan Carpenter
2021-04-21 15:47 ` Wong Vee Khee
2021-04-21 17:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-04-21 13:22 UTC (permalink / raw)
To: Giuseppe Cavallaro, Tan Tee Min
Cc: Alexandre Torgue, Jose Abreu, David S. Miller, Jakub Kicinski,
Maxime Coquelin, Wong Vee Khee, Richard Cochran, netdev,
linux-stm32, kernel-janitors
We recently added some new locking to this function but one error path
was overlooked. We need to drop the lock before returning.
Fixes: f4da56529da6 ("net: stmmac: Add support for external trigger timestamping")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
index ec140fc4a0f5..bd662aaf664a 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c
@@ -320,6 +320,7 @@ static int intel_crosststamp(ktime_t *device,
acr_value |= PTP_ACR_ATSEN3;
break;
default:
+ mutex_unlock(&priv->aux_ts_lock);
return -EINVAL;
}
writel(acr_value, ptpaddr + PTP_ACR);
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] stmmac: intel: unlock on error path in intel_crosststamp()
2021-04-21 13:22 [PATCH net-next] stmmac: intel: unlock on error path in intel_crosststamp() Dan Carpenter
@ 2021-04-21 15:47 ` Wong Vee Khee
2021-04-21 17:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Wong Vee Khee @ 2021-04-21 15:47 UTC (permalink / raw)
To: Dan Carpenter
Cc: Giuseppe Cavallaro, Tan Tee Min, Alexandre Torgue, Jose Abreu,
David S. Miller, Jakub Kicinski, Maxime Coquelin, Richard Cochran,
netdev, linux-stm32, kernel-janitors
On Wed, Apr 21, 2021 at 04:22:50PM +0300, Dan Carpenter wrote:
> We recently added some new locking to this function but one error path
> was overlooked. We need to drop the lock before returning.
>
> Fixes: f4da56529da6 ("net: stmmac: Add support for external trigger timestamping")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Wong Vee Khee <vee.khee.wong@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] stmmac: intel: unlock on error path in intel_crosststamp()
2021-04-21 13:22 [PATCH net-next] stmmac: intel: unlock on error path in intel_crosststamp() Dan Carpenter
2021-04-21 15:47 ` Wong Vee Khee
@ 2021-04-21 17:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-04-21 17:30 UTC (permalink / raw)
To: Dan Carpenter
Cc: peppe.cavallaro, tee.min.tan, alexandre.torgue, joabreu, davem,
kuba, mcoquelin.stm32, vee.khee.wong, richardcochran, netdev,
linux-stm32, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 21 Apr 2021 16:22:50 +0300 you wrote:
> We recently added some new locking to this function but one error path
> was overlooked. We need to drop the lock before returning.
>
> Fixes: f4da56529da6 ("net: stmmac: Add support for external trigger timestamping")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- [net-next] stmmac: intel: unlock on error path in intel_crosststamp()
https://git.kernel.org/netdev/net-next/c/53e35ebb9a17
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-21 17:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-21 13:22 [PATCH net-next] stmmac: intel: unlock on error path in intel_crosststamp() Dan Carpenter
2021-04-21 15:47 ` Wong Vee Khee
2021-04-21 17:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).