From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00760C433B4 for ; Thu, 22 Apr 2021 15:02:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FBD56143B for ; Thu, 22 Apr 2021 15:02:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236579AbhDVPDX (ORCPT ); Thu, 22 Apr 2021 11:03:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:44536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232670AbhDVPDW (ORCPT ); Thu, 22 Apr 2021 11:03:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5319461104; Thu, 22 Apr 2021 15:02:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619103767; bh=lA/GNSCyeI1Pj+t7+7DZpMGeLfmqJrRWrLGosSrK6NI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dIo9YENOn/jqah6mTJoOOfW5dx0ilFhk+oldljHkvNYNfeBDP4Z559+kL8RlFwiOY gK18FWdZu3Wk367DErbogzkk4jk9Akaw559EBGzyqDqGMOJyrouW1tBUpN+yLz9h42 x/N91/BL+qRLg7Yfjpc/QJbxSDZj0iflbp8o01A/mRxWAQT/ZEQ4PVuCHmSvz9I7bD VzXd8XBY6AGhbCe9DiMzlFCUbMMOpTX7MRu/vfKoP2cQj9YYnvjNNsxTc1bl3Npg0n rd0RiplcEqwdQ6j0+p8UkmbFVxNDE4dp69NvGHDxSe/bTXRW7xM1h3Qr1jDhwkBsE9 saEbW0EfpE+AQ== Date: Thu, 22 Apr 2021 18:02:42 +0300 From: Leon Romanovsky To: Loic Poulain Cc: kuba@kernel.org, davem@davemloft.net, netdev@vger.kernel.org Subject: Re: [PATCH net-next v2] net: wwan: core: Return poll error in case of port removal Message-ID: References: <1619100361-1330-1-git-send-email-loic.poulain@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1619100361-1330-1-git-send-email-loic.poulain@linaro.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 22, 2021 at 04:06:01PM +0200, Loic Poulain wrote: > Ensure that the poll system call returns proper error flags when port > is removed (nullified port ops), allowing user side to properly fail, > without further read or write. > > Fixes: 9a44c1cc6388 ("net: Add a WWAN subsystem") > Signed-off-by: Loic Poulain > --- > v2: get rid of useless locking for accessing port->ops > > drivers/net/wwan/wwan_core.c | 2 ++ > 1 file changed, 2 insertions(+) > Please take my ROB with a grain of salt. Thanks, Reviewed-by: Leon Romanovsky