From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B0BC433B4 for ; Fri, 23 Apr 2021 14:49:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D43F61452 for ; Fri, 23 Apr 2021 14:49:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241350AbhDWOuF (ORCPT ); Fri, 23 Apr 2021 10:50:05 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:38158 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbhDWOuE (ORCPT ); Fri, 23 Apr 2021 10:50:04 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lZx7P-000flm-68; Fri, 23 Apr 2021 16:49:19 +0200 Date: Fri, 23 Apr 2021 16:49:19 +0200 From: Andrew Lunn To: Linus Walleij Cc: netdev@vger.kernel.org, "David S . Miller" , Heiner Kallweit , Russell King , Zoltan HERPAI , Raylynn Knight , devicetree@vger.kernel.org Subject: Re: [PATCH 1/3 net-next v3] net: ethernet: ixp4xx: Add DT bindings Message-ID: References: <20210423082208.2244803-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210423082208.2244803-1-linus.walleij@linaro.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 23, 2021 at 10:22:06AM +0200, Linus Walleij wrote: > This adds device tree bindings for the IXP4xx ethernet > controller with optional MDIO bridge. Hi Linus That optional MDIO bus sentence is important here. I think it would be good to give examples for say IXP43x, where the MDIO bus is on NPE-C, and the phy-handles point from one Ethernet device in the device tree to the other. It is not unknown, but it is unusual, so giving an example is good. Also, looking at the unmodified driver, there is the global variable mdio_bus. This should contain the one MDIO bus for the cluster. With the C code, it should be impossible for multiple devices to instantiate an MDIO bus. But with device tree, is that still true? Should there be validation that only one device has an MDIO bus in its device tree? Andrew