From: Leon Romanovsky <leon@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
Yevgeny Kliteynik <kliteyn@nvidia.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net/mlx5: Fix some error messages
Date: Sun, 25 Apr 2021 09:39:29 +0300 [thread overview]
Message-ID: <YIUOoTKRwy3UTRWz@unreal> (raw)
In-Reply-To: <YIKywXhusLj4cDFM@mwanda>
On Fri, Apr 23, 2021 at 02:42:57PM +0300, Dan Carpenter wrote:
> This code was using IS_ERR() instead of PTR_ERR() so it prints 1 instead
> of the correct error code.
>
> Fixes: 25cb31768042 ("net/mlx5: E-Switch, Improve error messages in term table creation")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> .../mellanox/mlx5/core/eswitch_offloads_termtbl.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
It should go through netdev@.
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c
> index a81ece94f599..95f5c1a27718 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads_termtbl.c
> @@ -83,16 +83,16 @@ mlx5_eswitch_termtbl_create(struct mlx5_core_dev *dev,
> ft_attr.autogroup.max_num_groups = 1;
> tt->termtbl = mlx5_create_auto_grouped_flow_table(root_ns, &ft_attr);
> if (IS_ERR(tt->termtbl)) {
> - esw_warn(dev, "Failed to create termination table (error %d)\n",
> - IS_ERR(tt->termtbl));
> + esw_warn(dev, "Failed to create termination table (error %ld)\n",
> + PTR_ERR(tt->termtbl));
> return -EOPNOTSUPP;
> }
>
> tt->rule = mlx5_add_flow_rules(tt->termtbl, NULL, flow_act,
> &tt->dest, 1);
> if (IS_ERR(tt->rule)) {
> - esw_warn(dev, "Failed to create termination table rule (error %d)\n",
> - IS_ERR(tt->rule));
> + esw_warn(dev, "Failed to create termination table rule (error %ld)\n",
> + PTR_ERR(tt->rule));
> goto add_flow_err;
> }
> return 0;
> @@ -283,8 +283,8 @@ mlx5_eswitch_add_termtbl_rule(struct mlx5_eswitch *esw,
> tt = mlx5_eswitch_termtbl_get_create(esw, &term_tbl_act,
> &dest[i], attr);
> if (IS_ERR(tt)) {
> - esw_warn(esw->dev, "Failed to get termination table (error %d)\n",
> - IS_ERR(tt));
> + esw_warn(esw->dev, "Failed to get termination table (error %ld)\n",
> + PTR_ERR(tt));
> goto revert_changes;
> }
> attr->dests[num_vport_dests].termtbl = tt;
> --
> 2.30.2
>
next parent reply other threads:[~2021-04-25 6:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <YIKywXhusLj4cDFM@mwanda>
2021-04-25 6:39 ` Leon Romanovsky [this message]
2021-04-26 16:33 ` [PATCH net-next] net/mlx5: Fix some error messages Jakub Kicinski
2021-04-26 18:47 ` Saeed Mahameed
2021-04-27 5:08 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIUOoTKRwy3UTRWz@unreal \
--to=leon@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kliteyn@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).