From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D27D9C433B4 for ; Mon, 26 Apr 2021 10:17:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87ED2600CC for ; Mon, 26 Apr 2021 10:17:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232194AbhDZKRx (ORCPT ); Mon, 26 Apr 2021 06:17:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232173AbhDZKRw (ORCPT ); Mon, 26 Apr 2021 06:17:52 -0400 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76005C061574 for ; Mon, 26 Apr 2021 03:17:11 -0700 (PDT) Received: by mail-wm1-x331.google.com with SMTP id a22-20020a05600c2256b0290142870824e9so414591wmm.0 for ; Mon, 26 Apr 2021 03:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8+5RmGaKx5Tt6qhKXUKXBTfFBE8HCr3VUmHINr25V7Q=; b=coA7t6ZU+3D3rzonl2MD8DtCSIxY3Bhr4uKsu96mtDdzfd1ReGK6wCZtVh38ADMexc h0iVGJEbrn8P6LyrozH4sDaKslxXLK0zCaGUMo+2rH5MQkagWl25RZRfRiQ64WRP6j8Z S5BMEvU9z3yuqIaqKcSwNUSWYp8KvdUTE/q5unzz04xJK+hpibQiiS3sL7aRWXrgqXa7 rz7Mm1vD68LG1OBJeXHCGzk+Cafabfw0o6DCvXYZ60tdQ2uzZXztGBnggqfYRT9S2QQv fO5Iq5fyEsYMu54iVrhMLQty7HKqWSkdq8XmUOL4gMGVdswNg6+e71e996Lm3mlZZFJP Bx2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8+5RmGaKx5Tt6qhKXUKXBTfFBE8HCr3VUmHINr25V7Q=; b=TfcUVo1ljuk2OVrdZvtlSs8nNcyh4bRFW18DY8gUYMHbsorRQw6HnS2EoakR/wtQJM +7HffR9Pct7BJEPziWAc8ZfzakB4A75cZfM6Sd1HErpBzfaEZobsikDV3rhAt8hR+1Y2 VQTaZ+bantDGMmdB5k/3fclUryDnHtY5Y63CtLXJFcA2FHmxYN4hOjghtw3KnZrHsWbR bRKD4+ds/SU7mkw9j8/aG4E8zg8iJltvJiNlKNoSnOgEzMLyC0IGFvfCFzvYd31ZQ9pn NkzVcObLe2x/6JjQajBNWgfJGUXupEogkII+5b4vRbKGbXNB3ITJdMFrD4qbT24ipb4g iCCQ== X-Gm-Message-State: AOAM5326uIHkwa1a0oG/AAsllUmim4mGZ1+okfuEBQe3jV1SAqSmC9aa luFM4NlnvItNI09XA9Txl7J3Vg== X-Google-Smtp-Source: ABdhPJwYsZ5Bdm0jMDlAvLoRue+X2IuYqd6A0q8UkP92NgRfMr63EtUQ2jnm3b8u++7Sr4Bji8w4vg== X-Received: by 2002:a1c:6244:: with SMTP id w65mr20538092wmb.27.1619432229857; Mon, 26 Apr 2021 03:17:09 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:de72:8b77:f30e:ff1e]) by smtp.gmail.com with ESMTPSA id a2sm20837694wrt.82.2021.04.26.03.17.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Apr 2021 03:17:09 -0700 (PDT) Date: Mon, 26 Apr 2021 11:17:08 +0100 From: Matthias Maennich To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, Benjamin Herrenschmidt , "David S. Miller" , Jakub Kicinski , Mat Martineau , Matthieu Baerts , Michael Ellerman , Paul Mackerras , Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, mptcp@lists.01.org, netdev@vger.kernel.org Subject: Re: [PATCH] kbuild: replace LANG=C with LC_ALL=C Message-ID: References: <20210424114841.394239-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210424114841.394239-1-masahiroy@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Apr 24, 2021 at 08:48:41PM +0900, Masahiro Yamada wrote: >LANG gives a weak default to each LC_* in case it is not explicitly >defined. LC_ALL, if set, overrides all other LC_* variables. > > LANG < LC_CTYPE, LC_COLLATE, LC_MONETARY, LC_NUMERIC, ... < LC_ALL > >This is why documentation such as [1] suggests to set LC_ALL in build >scripts to get the deterministic result. > >LANG=C is not strong enough to override LC_* that may be set by end >users. > >[1]: https://reproducible-builds.org/docs/locales/ > >Signed-off-by: Masahiro Yamada Reviewed-by: Matthias Maennich Cheers, Matthias >--- > > arch/powerpc/boot/wrapper | 2 +- > scripts/nsdeps | 2 +- > scripts/recordmcount.pl | 2 +- > scripts/setlocalversion | 2 +- > scripts/tags.sh | 2 +- > tools/testing/selftests/net/mptcp/mptcp_connect.sh | 2 +- > usr/gen_initramfs.sh | 2 +- > 7 files changed, 7 insertions(+), 7 deletions(-) > >diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper >index 41fa0a8715e3..cdb796b76e2e 100755 >--- a/arch/powerpc/boot/wrapper >+++ b/arch/powerpc/boot/wrapper >@@ -191,7 +191,7 @@ if [ -z "$kernel" ]; then > kernel=vmlinux > fi > >-LANG=C elfformat="`${CROSS}objdump -p "$kernel" | grep 'file format' | awk '{print $4}'`" >+LC_ALL=C elfformat="`${CROSS}objdump -p "$kernel" | grep 'file format' | awk '{print $4}'`" > case "$elfformat" in > elf64-powerpcle) format=elf64lppc ;; > elf64-powerpc) format=elf32ppc ;; >diff --git a/scripts/nsdeps b/scripts/nsdeps >index e8ce2a4d704a..04c4b96e95ec 100644 >--- a/scripts/nsdeps >+++ b/scripts/nsdeps >@@ -44,7 +44,7 @@ generate_deps() { > for source_file in $mod_source_files; do > sed '/MODULE_IMPORT_NS/Q' $source_file > ${source_file}.tmp > offset=$(wc -l ${source_file}.tmp | awk '{print $1;}') >- cat $source_file | grep MODULE_IMPORT_NS | LANG=C sort -u >> ${source_file}.tmp >+ cat $source_file | grep MODULE_IMPORT_NS | LC_ALL=C sort -u >> ${source_file}.tmp > tail -n +$((offset +1)) ${source_file} | grep -v MODULE_IMPORT_NS >> ${source_file}.tmp > if ! diff -q ${source_file} ${source_file}.tmp; then > mv ${source_file}.tmp ${source_file} >diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl >index 867860ea57da..0a7fc9507d6f 100755 >--- a/scripts/recordmcount.pl >+++ b/scripts/recordmcount.pl >@@ -497,7 +497,7 @@ sub update_funcs > # > # Step 2: find the sections and mcount call sites > # >-open(IN, "LANG=C $objdump -hdr $inputfile|") || die "error running $objdump"; >+open(IN, "LC_ALL=C $objdump -hdr $inputfile|") || die "error running $objdump"; > > my $text; > >diff --git a/scripts/setlocalversion b/scripts/setlocalversion >index bb709eda96cd..db941f6d9591 100755 >--- a/scripts/setlocalversion >+++ b/scripts/setlocalversion >@@ -126,7 +126,7 @@ scm_version() > fi > > # Check for svn and a svn repo. >- if rev=$(LANG= LC_ALL= LC_MESSAGES=C svn info 2>/dev/null | grep '^Last Changed Rev'); then >+ if rev=$(LC_ALL=C svn info 2>/dev/null | grep '^Last Changed Rev'); then > rev=$(echo $rev | awk '{print $NF}') > printf -- '-svn%s' "$rev" > >diff --git a/scripts/tags.sh b/scripts/tags.sh >index fd96734deff1..db8ba411860a 100755 >--- a/scripts/tags.sh >+++ b/scripts/tags.sh >@@ -326,5 +326,5 @@ esac > > # Remove structure forward declarations. > if [ -n "$remove_structs" ]; then >- LANG=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' $1 >+ LC_ALL=C sed -i -e '/^\([a-zA-Z_][a-zA-Z0-9_]*\)\t.*\t\/\^struct \1;.*\$\/;"\tx$/d' $1 > fi >diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh >index 10a030b53b23..1d2a6e7b877c 100755 >--- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh >+++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh >@@ -273,7 +273,7 @@ check_mptcp_disabled() > ip netns exec ${disabled_ns} sysctl -q net.mptcp.enabled=0 > > local err=0 >- LANG=C ip netns exec ${disabled_ns} ./mptcp_connect -t $timeout -p 10000 -s MPTCP 127.0.0.1 < "$cin" 2>&1 | \ >+ LC_ALL=C ip netns exec ${disabled_ns} ./mptcp_connect -t $timeout -p 10000 -s MPTCP 127.0.0.1 < "$cin" 2>&1 | \ > grep -q "^socket: Protocol not available$" && err=1 > ip netns delete ${disabled_ns} > >diff --git a/usr/gen_initramfs.sh b/usr/gen_initramfs.sh >index 8ae831657e5d..63476bb70b41 100755 >--- a/usr/gen_initramfs.sh >+++ b/usr/gen_initramfs.sh >@@ -147,7 +147,7 @@ dir_filelist() { > header "$1" > > srcdir=$(echo "$1" | sed -e 's://*:/:g') >- dirlist=$(find "${srcdir}" -printf "%p %m %U %G\n" | LANG=C sort) >+ dirlist=$(find "${srcdir}" -printf "%p %m %U %G\n" | LC_ALL=C sort) > > # If $dirlist is only one line, then the directory is empty > if [ "$(echo "${dirlist}" | wc -l)" -gt 1 ]; then >-- >2.27.0 >