From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 818ADC433ED for ; Fri, 30 Apr 2021 12:52:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45E4461477 for ; Fri, 30 Apr 2021 12:52:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232048AbhD3MxD (ORCPT ); Fri, 30 Apr 2021 08:53:03 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47748 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230289AbhD3MxA (ORCPT ); Fri, 30 Apr 2021 08:53:00 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lcScp-001oTE-Ov; Fri, 30 Apr 2021 14:52:07 +0200 Date: Fri, 30 Apr 2021 14:52:07 +0200 From: Andrew Lunn To: Huazhong Tan Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, salil.mehta@huawei.com, yisen.zhuang@huawei.com, huangdaode@huawei.com, linuxarm@openeuler.org, linuxarm@huawei.com, Yufeng Mo Subject: Re: [PATCH net-next 4/4] net: hns3: disable phy loopback setting in hclge_mac_start_phy Message-ID: References: <1619773582-17828-1-git-send-email-tanhuazhong@huawei.com> <1619773582-17828-5-git-send-email-tanhuazhong@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1619773582-17828-5-git-send-email-tanhuazhong@huawei.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Apr 30, 2021 at 05:06:22PM +0800, Huazhong Tan wrote: > From: Yufeng Mo > > If selftest and reset are performed at the same time, the phy > loopback setting may be still in enable state after the reset, > and device cannot link up. So fix this issue by disabling phy > loopback before phy_start(). This sounds like a generic problem, not specific to your driver. Please look at solving this within phy_start(). Andrew