From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35262C433B4 for ; Tue, 11 May 2021 19:58:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED2ED617ED for ; Tue, 11 May 2021 19:58:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229871AbhEKT7i (ORCPT ); Tue, 11 May 2021 15:59:38 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:46719 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbhEKT7i (ORCPT ); Tue, 11 May 2021 15:59:38 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 73CAE5C0178; Tue, 11 May 2021 15:58:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 11 May 2021 15:58:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=w9En54 sELRkrvjsaCzYH+PrjQAJ9pi+3hV73917lLdg=; b=WTlpekK/dTiqrrmkvqFOvy bZnxQ7yjnFvw1uFRweqQNyyletONl1RPSDMRtABxgefLG6X2VppCm1HGV4dLmRWg wibf8pallLLQxeDbTsZBieEP2Gk0QysJYEGRyBL35btqIKvgtfDI/8MOXLCJth/R 4+MVde5KIkcneGXAx1h5jebqJNoK2pz959pOhDMz2sOE54KHMSWfujzDhw34CHmo x4twPuV8FDMD1+RSnhpz/UiVgCNLF7aZORkVEWnXioIwMZ7IwrZipTwYZF6XsucV PQA8kUjO8EL/qujrVZmqhfBZMvG1z3ajL3hJDrpEYRBa9eMc56Ql/5QK2F/TKfdA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehtddgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnheptdffkeekfeduffevgeeujeffjefhtefgueeugfevtdeiheduueeukefhudeh leetnecukfhppeekgedrvddvledrudehfedrudekjeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Received: from localhost (igld-84-229-153-187.inter.net.il [84.229.153.187]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 11 May 2021 15:58:29 -0400 (EDT) Date: Tue, 11 May 2021 22:58:26 +0300 From: Ido Schimmel To: David Ahern Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, petrm@nvidia.com, roopa@nvidia.com, nikolay@nvidia.com, ssuryaextr@gmail.com, mlxsw@nvidia.com, Ido Schimmel Subject: Re: [RFC PATCH net-next v2 02/10] ipv4: Add a sysctl to control multipath hash fields Message-ID: References: <20210509151615.200608-1-idosch@idosch.org> <20210509151615.200608-3-idosch@idosch.org> <59331028-c1a5-2a7a-1e27-57e62f95030f@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59331028-c1a5-2a7a-1e27-57e62f95030f@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, May 11, 2021 at 09:10:46AM -0600, David Ahern wrote: > On 5/9/21 9:16 AM, Ido Schimmel wrote: > > diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst > > index c2ecc9894fd0..15982f830abc 100644 > > --- a/Documentation/networking/ip-sysctl.rst > > +++ b/Documentation/networking/ip-sysctl.rst > > @@ -100,6 +100,33 @@ fib_multipath_hash_policy - INTEGER > > - 1 - Layer 4 > > - 2 - Layer 3 or inner Layer 3 if present > > > > +fib_multipath_hash_fields - UNSIGNED INTEGER > > + When fib_multipath_hash_policy is set to 3 (custom multipath hash), the > > + fields used for multipath hash calculation are determined by this > > + sysctl. > > + > > + This value is a bitmask which enables various fields for multipath hash > > + calculation. > > + > > + Possible fields are: > > + > > + ====== ============================ > > + 0x0001 Source IP address > > + 0x0002 Destination IP address > > + 0x0004 IP protocol > > + 0x0008 Unused > > Document that this bit is flowlabel for IPv6 and ignored for ipv4. OK