From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Network Development <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, Sasha Levin <sashal@kernel.org>
Subject: Re: [QUESTION] BPF kernel selftests failed in the LTS stable kernel 4.19.x
Date: Thu, 27 May 2021 10:37:12 +0200 [thread overview]
Message-ID: <YK9aOGGO033adyw1@kroah.com> (raw)
In-Reply-To: <9671b7f4-b827-3c81-f1e5-2836c701495b@loongson.cn>
On Thu, May 27, 2021 at 04:18:15PM +0800, Tiezhu Yang wrote:
> On 05/27/2021 12:24 PM, Greg Kroah-Hartman wrote:
> > On Thu, May 27, 2021 at 10:27:51AM +0800, Tiezhu Yang wrote:
> > > Hi all,
> > >
> > > When update the following LTS stable kernel 4.19.x,
> > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/?h=linux-4.19.y
> > >
> > > and then run BPF selftests according to
> > > https://www.kernel.org/doc/html/latest/bpf/bpf_devel_QA.html#q-how-to-run-bpf-selftests
> > >
> > > $ cd tools/testing/selftests/bpf/
> > > $ make
> > > $ sudo ./test_verifier
> > > $ sudo make run_tests
> > >
> > > there exists many failures include verifier tests and run_tests,
> > > (1) is it necessary to make sure that there are no any failures in the LTS
> > > stable kernel 4.19.x?
> > Yes, it would be nice if that did not happen.
> >
> > > (2) if yes, how to fix these failures in the LTS stable kernel 4.19.x?
> > Can you find the offending commits by using `git bisect` and find the
> > upstream commits that resolve this and let us know so we can backport
> > them?
> >
> > thanks,
> >
> > greg k-h
>
> I compared the related code in 4.19.y and upstream mainline, some failures
> disappeared after add ".flags = F_NEEDS_EFFICIENT_UNALIGNED_ACCESS,", but
> other failures still exist, and I didn't have enough in-depth knowledge to
> touch things elsewhere.
>
> The failures can be easily reproduced, I would greatly appreciate it if
> anyone
> is interested to fix them.
Sounds like you are interested, why not work on this instead of waiting
for someone else? It's not like many people are interested in 4.19 at
this point in time.
good luck!
greg k-h
prev parent reply other threads:[~2021-05-27 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 2:27 [QUESTION] BPF kernel selftests failed in the LTS stable kernel 4.19.x Tiezhu Yang
2021-05-27 4:24 ` Greg Kroah-Hartman
2021-05-27 8:18 ` Tiezhu Yang
2021-05-27 8:37 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YK9aOGGO033adyw1@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=songliubraving@fb.com \
--cc=yangtiezhu@loongson.cn \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).