public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: David Ahern <dsahern@kernel.org>
Cc: stephen@networkplumber.org, netdev@vger.kernel.org,
	heiko.thiery@gmail.com
Subject: Re: [PATCH iproute2-next] config.mk: Rerun configure when it is newer than config.mk
Date: Sat, 15 May 2021 22:16:54 +0200	[thread overview]
Message-ID: <YKAsNriY7P53v7Dw@pevik> (raw)
In-Reply-To: <20210515201320.7435-1-dsahern@kernel.org>

Hi David,

> config.mk needs to be re-generated any time configure is changed.
> Rename the existing make target and add a check that the config.mk
> file needs to exist and must be newer than configure script.

> Signed-off-by: David Ahern <dsahern@kernel.org>
> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
Tested-by: Petr Vorel <petr.vorel@gmail.com>

Thanks!

Kind regards,
Petr

> ---
>  Makefile | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

> diff --git a/Makefile b/Makefile
> index 19bd163e2e04..5bc11477ab7a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -60,7 +60,7 @@ SUBDIRS=lib ip tc bridge misc netem genl tipc devlink rdma dcb man vdpa
>  LIBNETLINK=../lib/libutil.a ../lib/libnetlink.a
>  LDLIBS += $(LIBNETLINK)

> -all: config.mk
> +all: config
>  	@set -e; \
>  	for i in $(SUBDIRS); \
>  	do echo; echo $$i; $(MAKE) -C $$i; done
> @@ -80,8 +80,10 @@ all: config.mk
>  	@echo "Make Arguments:"
>  	@echo " V=[0|1]             - set build verbosity level"

> -config.mk:
> -	sh configure $(KERNEL_INCLUDE)
> +config:
> +	@if [ ! -f config.mk -o configure -nt config.mk ]; then \
> +		sh configure $(KERNEL_INCLUDE); \
> +	fi

>  install: all
>  	install -m 0755 -d $(DESTDIR)$(SBINDIR)

      reply	other threads:[~2021-05-15 20:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-15 20:13 [PATCH iproute2-next] config.mk: Rerun configure when it is newer than config.mk David Ahern
2021-05-15 20:16 ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKAsNriY7P53v7Dw@pevik \
    --to=petr.vorel@gmail.com \
    --cc=dsahern@kernel.org \
    --cc=heiko.thiery@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox