From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5585C4743C for ; Fri, 4 Jun 2021 20:12:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D13D613F9 for ; Fri, 4 Jun 2021 20:12:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230411AbhFDUM1 (ORCPT ); Fri, 4 Jun 2021 16:12:27 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46050 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229791AbhFDUM1 (ORCPT ); Fri, 4 Jun 2021 16:12:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=BbAFLGrGgY2oihriyQ//wQ5WcXkq7Kyp0Q/UXBGCxb0=; b=YuiSZcWNbcdMmIPkjb14TJ9uKw M1ksNIkWXBOHbISbw/ZGaFB3qDOzUjJI86hi6/NFTydyb2hS8CBywwFSOuiQV8wv3Mr5RRprCVnWu tXywOIm7tAFCHpu8u2W+yPHDTGjBlFQPgQQzGaW9w2qOnFfNbCRrIpkeE0IdJiwvNczA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lpG9M-007qju-N2; Fri, 04 Jun 2021 22:10:36 +0200 Date: Fri, 4 Jun 2021 22:10:36 +0200 From: Andrew Lunn To: Liang Xu Cc: Florian Fainelli , "hkallweit1@gmail.com" , "netdev@vger.kernel.org" , "davem@davemloft.net" , "kuba@kernel.org" , "vee.khee.wong@linux.intel.com" , "linux@armlinux.org.uk" , Hauke Mehrtens , Thomas Mohren Subject: Re: [PATCH v3] net: phy: add Maxlinear GPY115/21x/24x driver Message-ID: References: <20210604161250.49749-1-lxu@maxlinear.com> <7834258b-5826-1c00-2754-b0b7e76b5910@maxlinear.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7834258b-5826-1c00-2754-b0b7e76b5910@maxlinear.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > > +static int gpy_read_abilities(struct phy_device *phydev) > > > +{ > > > + int ret; > > > + > > > + ret = genphy_read_abilities(phydev); > > > + if (ret < 0) > > > + return ret; > > > + > > > + /* Detect 2.5G/5G support. */ > > > + ret = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_STAT2); > > > + if (ret < 0) > > > + return ret; > > > + if (!(ret & MDIO_PMA_STAT2_EXTABLE)) > > > + return 0; > > > + > > > + ret = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_EXTABLE); > > > + if (ret < 0) > > > + return ret; > > > + if (!(ret & MDIO_PMA_EXTABLE_NBT)) > > > + return 0; > > > + > > > + ret = phy_read_mmd(phydev, MDIO_MMD_PMAPMD, MDIO_PMA_NG_EXTABLE); > > > + if (ret < 0) > > > + return ret; > > > + > > > + linkmode_mod_bit(ETHTOOL_LINK_MODE_2500baseT_Full_BIT, > > > + phydev->supported, > > > + ret & MDIO_PMA_NG_EXTABLE_2_5GBT); > > > + > > > + linkmode_mod_bit(ETHTOOL_LINK_MODE_5000baseT_Full_BIT, > > > + phydev->supported, > > > + ret & MDIO_PMA_NG_EXTABLE_5GBT); > > > > This does not access vendor specific registers, should not this be part > > of the standard genphy_read_abilities() or moved to a helper? > > > genphy_read_abilities does not cover 2.5G. > > genphy_c45_pma_read_abilities checks C45 ids and this check fail if > is_c45 is not set. You appear to of ignored my comment about this. Please add the helper to the core as i suggested, and then use genphy_c45_pma_read_abilities(). Andrew