From: Andrew Lunn <andrew@lunn.ch>
To: Liang Xu <lxu@maxlinear.com>
Cc: "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"vee.khee.wong@linux.intel.com" <vee.khee.wong@linux.intel.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
Hauke Mehrtens <hmehrtens@maxlinear.com>,
Thomas Mohren <tmohren@maxlinear.com>
Subject: Re: [PATCH v2] net: phy: add Maxlinear GPY115/21x/24x driver
Date: Fri, 4 Jun 2021 22:39:58 +0200 [thread overview]
Message-ID: <YLqPnpNXbd6o019o@lunn.ch> (raw)
In-Reply-To: <797fe98f-ab65-8633-dadc-beed56d251d0@maxlinear.com>
On Fri, Jun 04, 2021 at 12:52:02PM +0000, Liang Xu wrote:
> On 4/6/2021 8:15 pm, Andrew Lunn wrote:
> > This email was sent from outside of MaxLinear.
> >
> >
> >> +config MXL_GPHY
> >> + tristate "Maxlinear PHYs"
> >> + help
> >> + Support for the Maxlinear GPY115, GPY211, GPY212, GPY215,
> >> + GPY241, GPY245 PHYs.
> > Do these PHYs have unique IDs in register 2 and 3? What is the format
> > of these IDs?
> >
> > The OUI is fixed. But often the rest is split into two. The higher
> > part indicates the product, and the lower part is the revision. We
> > then have a struct phy_driver for each product, and the mask is used
> > to match on all the revisions of the product.
> >
> > Andrew
> >
> Register 2, Register 3 bit 10~15 - OUI
>
> Register 3 bit 4~9 - product number
>
> Register 3 bit 0~3 - revision number
>
> These PHYs have same ID in register 2 and 3.
O.K, that is pretty normal. Please add a phy_device for each
individual PHY. There are macros to help you do this.
Andrew
next prev parent reply other threads:[~2021-06-04 20:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 7:34 [PATCH v2] net: phy: add Maxlinear GPY115/21x/24x driver Xu Liang
2021-06-03 9:17 ` Russell King (Oracle)
2021-06-03 10:36 ` Liang Xu
2021-06-03 15:10 ` Liang Xu
2021-06-03 15:21 ` Andrew Lunn
2021-06-03 15:32 ` Liang Xu
2021-06-03 17:05 ` Andrew Lunn
2021-06-03 17:54 ` Liang Xu
2021-06-04 12:09 ` Andrew Lunn
2021-06-04 12:39 ` Liang Xu
2021-06-04 12:15 ` Andrew Lunn
2021-06-04 12:52 ` Liang Xu
2021-06-04 20:39 ` Andrew Lunn [this message]
2021-06-05 3:46 ` Liang Xu
2021-06-05 14:37 ` Andrew Lunn
2021-06-07 4:04 ` Liang Xu
2021-06-07 12:15 ` Andrew Lunn
2021-06-07 13:28 ` Liang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLqPnpNXbd6o019o@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=hmehrtens@maxlinear.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=tmohren@maxlinear.com \
--cc=vee.khee.wong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).