From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3A57C4743D for ; Fri, 4 Jun 2021 20:40:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA0D2613B4 for ; Fri, 4 Jun 2021 20:40:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231441AbhFDUlr (ORCPT ); Fri, 4 Jun 2021 16:41:47 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46122 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229854AbhFDUlq (ORCPT ); Fri, 4 Jun 2021 16:41:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=m+QYsXtela9hi8J1/G3KHsdwFHjEwfV4evj5iomCfyc=; b=c1LQHFC2cd7Vs30Y233twMpsOx nIAo8wsA/1qrcFYzXmf4ZVrG5MQqrWrVFnROzA+b2SbrvqYS2yax6Dv6wZGy7d/J8RpKv+bT45h2H BpK1DJpo2jETcA3L3DhkudxymFjf2XjRh1jkVmfu4LGe6eXS2lMLJUGxtOUman5jRm8g=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lpGbm-007qwP-Oy; Fri, 04 Jun 2021 22:39:58 +0200 Date: Fri, 4 Jun 2021 22:39:58 +0200 From: Andrew Lunn To: Liang Xu Cc: "hkallweit1@gmail.com" , "netdev@vger.kernel.org" , "davem@davemloft.net" , "kuba@kernel.org" , "vee.khee.wong@linux.intel.com" , "linux@armlinux.org.uk" , Hauke Mehrtens , Thomas Mohren Subject: Re: [PATCH v2] net: phy: add Maxlinear GPY115/21x/24x driver Message-ID: References: <20210603073438.33967-1-lxu@maxlinear.com> <797fe98f-ab65-8633-dadc-beed56d251d0@maxlinear.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <797fe98f-ab65-8633-dadc-beed56d251d0@maxlinear.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jun 04, 2021 at 12:52:02PM +0000, Liang Xu wrote: > On 4/6/2021 8:15 pm, Andrew Lunn wrote: > > This email was sent from outside of MaxLinear. > > > > > >> +config MXL_GPHY > >> + tristate "Maxlinear PHYs" > >> + help > >> + Support for the Maxlinear GPY115, GPY211, GPY212, GPY215, > >> + GPY241, GPY245 PHYs. > > Do these PHYs have unique IDs in register 2 and 3? What is the format > > of these IDs? > > > > The OUI is fixed. But often the rest is split into two. The higher > > part indicates the product, and the lower part is the revision. We > > then have a struct phy_driver for each product, and the mask is used > > to match on all the revisions of the product. > > > > Andrew > > > Register 2, Register 3 bit 10~15 - OUI > > Register 3 bit 4~9 - product number > > Register 3 bit 0~3 - revision number > > These PHYs have same ID in register 2 and 3. O.K, that is pretty normal. Please add a phy_device for each individual PHY. There are macros to help you do this. Andrew