From: Andrew Lunn <andrew@lunn.ch>
To: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Cc: Joakim Zhang <qiangqing.zhang@nxp.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V3 net-next 3/4] net: phy: realtek: add dt property to enable ALDPS mode
Date: Wed, 9 Jun 2021 14:17:44 +0200 [thread overview]
Message-ID: <YMCxaAOs2UYRHEnF@lunn.ch> (raw)
In-Reply-To: <20210609110428.5a136b03@xhacker.debian>
> Aha, I see you want to keep the ALDPS bits(maybe configured by prelinux env) untouched.
> If ALDPS has been enabled by prelinux env, even there's no "realtek,aldps-enable"
> in DT, the ALDPS may be keep enabled in linux. Thus the ALDPS behavior rely on
> the prelinux env. I'm not sure whether this is correct or not.
>
> IMHO, the "realtek,aldps-enable" is a "yes" or "no" bool. If it's set, ALDPS
> will be enabled in linux; If it's no, ALDPS will be disabled in linux. We
> should not rely on prelinux env.
If you look at V1 of this patch, you will see i commented that maybe
it needs to be a tristate, not a boolean. Disable it, enable it, leave
it as is. If we do need the third state, we can add it latter.
There is something to be said for not relying on the bootloader. But
the hardware default appears to be ALDPS enabled. So this case seems
reasonably safe.
Andrew
next prev parent reply other threads:[~2021-06-09 12:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 3:15 [PATCH V3 net-next 0/4] net: phy: add dt property for realtek phy Joakim Zhang
2021-06-08 3:15 ` [PATCH V3 net-next 1/4] dt-bindings: net: add dt binding for realtek rtl82xx phy Joakim Zhang
2021-06-10 2:54 ` Rob Herring
2021-06-08 3:15 ` [PATCH V3 net-next 2/4] net: phy: realtek: add dt property to disable CLKOUT clock Joakim Zhang
2021-06-08 3:15 ` [PATCH V3 net-next 3/4] net: phy: realtek: add dt property to enable ALDPS mode Joakim Zhang
2021-06-08 9:51 ` Jisheng Zhang
2021-06-08 10:14 ` Joakim Zhang
2021-06-09 1:56 ` Jisheng Zhang
2021-06-09 2:51 ` Joakim Zhang
2021-06-09 3:04 ` Jisheng Zhang
2021-06-09 3:55 ` Joakim Zhang
2021-06-09 12:17 ` Andrew Lunn [this message]
2021-06-08 3:15 ` [PATCH V3 net-next 4/4] net: phy: realtek: add delay to fix RXC generation issue Joakim Zhang
2021-06-08 18:50 ` [PATCH V3 net-next 0/4] net: phy: add dt property for realtek phy patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMCxaAOs2UYRHEnF@lunn.ch \
--to=andrew@lunn.ch \
--cc=Jisheng.Zhang@synaptics.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).