Re: [PATCH 14/19] libbpf: Add btf__find_by_pattern_kind function

Jiri Olsa
2021-06-09T14:19:41Z

On Wed, Jun 09, 2021 at 03:59:47PM +0200, Jiri Olsa wrote:

SNIP

> > > +
> > > + /* When the pattern does not start with wildcard, treat it as
> > > + * if we'd want to match it from the beginning of the string.
> > > + */
> >
> > This assumption is absolutely atrocious. If we say it's regexp, then
> > it has to always be regexp, not something based on some random
> > heuristic based on the first character.
> >
> > Taking a step back, though. Do we really need to provide this API? Why
> > applications can't implement it on their own, given regexp
> > functionality is provided by libc. Which I didn't know, actually, so
> > that's pretty nice, assuming that it's also available in more minimal
> > implementations like musl.
> >
>
> so the only purpose for this function is to support wildcards in
> tests like:
>
> SEC("fentry.multi/bpf_fentry_test*")
>
> so the generic skeleton attach function can work.. but that can be
> removed and the test programs can be attached manually through some
> other attach function that will have list of functions as argument

nah, no other attach function is needed, we have that support now in
link_create ready to use ;-) sry

jirka