Re: [PATCH 03/19] x86/ftrace: Make function graph use ftrace directly

Steven Rostedt
2021-06-08T19:20:23Z

On Tue, 8 Jun 2021 20:51:25 +0200
Jiri Olsa <jolsa@redhat.com> wrote:

> > > + FTRACE_OPS_FL_PID
> > > + FTRACE_OPS_GRAPH_STUB,
> >
> > nit: this looks so weird... Why not define FTRACE_OPS_GRAPH_STUB as
> > zero in case of #ifdef ftrace_graph_func? Then it will be natural and
> > correctly looking | FTRACE_OPS_GRAPH_STUB?

I have no idea why I did that :-/ But it was a while ago when I wrote
this code. I think there was a reason for it, but with various updates,
that reason disappeared.

>
> ok, I can change that

Yes, please do.

Thanks,

-- Steve