From: Leon Romanovsky <leon@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: saeedm@nvidia.com, davem@davemloft.net, kuba@kernel.org,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx5: Fix missing error code in mlx5_init_fs()
Date: Wed, 16 Jun 2021 09:19:13 +0300 [thread overview]
Message-ID: <YMmX4ZvDfODFHUx2@unreal> (raw)
In-Reply-To: <1623754695-86508-1-git-send-email-jiapeng.chong@linux.alibaba.com>
On Tue, Jun 15, 2021 at 06:58:15PM +0800, Jiapeng Chong wrote:
> The error code is missing in this code scenario, add the error code
> '-ENOMEM' to the return value 'err'.
>
> Eliminate the follow smatch warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:2973 mlx5_init_fs()
> warn: missing error code 'err'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Can you please add fixes lines to your patches like all fix patches should?
Fixes: 4a98544d1827 ("net/mlx5: Move chains ft pool to be used by all firmware steering")
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
prev parent reply other threads:[~2021-06-16 6:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 10:58 [PATCH] net/mlx5: Fix missing error code in mlx5_init_fs() Jiapeng Chong
2021-06-16 6:19 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMmX4ZvDfODFHUx2@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).