From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B945C48BE8 for ; Wed, 16 Jun 2021 06:19:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E6EE6109D for ; Wed, 16 Jun 2021 06:19:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231326AbhFPGVq (ORCPT ); Wed, 16 Jun 2021 02:21:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:53470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231252AbhFPGVn (ORCPT ); Wed, 16 Jun 2021 02:21:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 78144613BF; Wed, 16 Jun 2021 06:19:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623824357; bh=BFEK30sTNGFcJp3RIsT5M5bMegNIg9neaNx3+8EdaIo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qjLUpX2fF+Q3ihTJ9FOQc1Hcw9cy3Wf+zwnnyseYPYs5yh5KLhDv+T34MngYN6SPe g5ELxK/aWo64jspizP08eNANqORKispINDLVlFV/YP28JcMzitESF0d6oS1xe3IkYp cFN/EwKZcOBwGLW9eU8l6XRklrVzPReKcb81qhGXxdn6z1mFVmT8qZyHZSFhXc0zWX nahx0Zcam0Ryq9LtAsadtx0Hlax2PyDNoqKpSvxvxW9afN8LYHdD0dgaKCfTfVWNbP dn+RknkCTw96+LzYq/sh4KvOpZr5ZjtLnPHd6qvb00/7XYN4+NChYw9vrk2rcrfO4p i6lqb/T3wvMDA== Date: Wed, 16 Jun 2021 09:19:13 +0300 From: Leon Romanovsky To: Jiapeng Chong Cc: saeedm@nvidia.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/mlx5: Fix missing error code in mlx5_init_fs() Message-ID: References: <1623754695-86508-1-git-send-email-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623754695-86508-1-git-send-email-jiapeng.chong@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jun 15, 2021 at 06:58:15PM +0800, Jiapeng Chong wrote: > The error code is missing in this code scenario, add the error code > '-ENOMEM' to the return value 'err'. > > Eliminate the follow smatch warning: > > drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:2973 mlx5_init_fs() > warn: missing error code 'err'. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Can you please add fixes lines to your patches like all fix patches should? Fixes: 4a98544d1827 ("net/mlx5: Move chains ft pool to be used by all firmware steering") Thanks, Reviewed-by: Leon Romanovsky