* [PATCH] net/mlx5: Fix missing error code in mlx5_init_fs()
@ 2021-06-15 10:58 Jiapeng Chong
2021-06-16 6:19 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-06-15 10:58 UTC (permalink / raw)
To: saeedm; +Cc: leon, davem, kuba, netdev, linux-rdma, linux-kernel,
Jiapeng Chong
The error code is missing in this code scenario, add the error code
'-ENOMEM' to the return value 'err'.
Eliminate the follow smatch warning:
drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:2973 mlx5_init_fs()
warn: missing error code 'err'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
index 2cd7aea..b861745 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
@@ -2969,8 +2969,11 @@ int mlx5_init_fs(struct mlx5_core_dev *dev)
return err;
steering = kzalloc(sizeof(*steering), GFP_KERNEL);
- if (!steering)
+ if (!steering) {
+ err = -ENOMEM;
goto err;
+ }
+
steering->dev = dev;
dev->priv.steering = steering;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net/mlx5: Fix missing error code in mlx5_init_fs()
2021-06-15 10:58 [PATCH] net/mlx5: Fix missing error code in mlx5_init_fs() Jiapeng Chong
@ 2021-06-16 6:19 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2021-06-16 6:19 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: saeedm, davem, kuba, netdev, linux-rdma, linux-kernel
On Tue, Jun 15, 2021 at 06:58:15PM +0800, Jiapeng Chong wrote:
> The error code is missing in this code scenario, add the error code
> '-ENOMEM' to the return value 'err'.
>
> Eliminate the follow smatch warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:2973 mlx5_init_fs()
> warn: missing error code 'err'.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Can you please add fixes lines to your patches like all fix patches should?
Fixes: 4a98544d1827 ("net/mlx5: Move chains ft pool to be used by all firmware steering")
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-16 6:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-15 10:58 [PATCH] net/mlx5: Fix missing error code in mlx5_init_fs() Jiapeng Chong
2021-06-16 6:19 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).