From: Kev Jackson <foamdino@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: mkubecek@suse.cz, netdev@vger.kernel.org
Subject: Re: ethtool discrepancy between observed behaviour and comments
Date: Wed, 16 Jun 2021 10:50:38 +0100 [thread overview]
Message-ID: <YMnJbl1KiB4EaPVP@linux-dev> (raw)
In-Reply-To: <20210615124050.50138c05@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Hi,
On Tue, Jun 15, 2021 at 12:40:50PM -0700, Jakub Kicinski wrote:
> I'm not sure I grasped what the problem is. Could you perhaps share
> what you're trying to do that works with netlink vs IOCTL? Best if
> it's in form of:
>
> $ ethtool -l $ifc
> $ ./ethtool-ioctl -L $ifc ...
> # presumably fails IIUC?
> $ ./ethtool-nl -L $ifc ...
> # and this one succeeds?
>
> where ethtool-ioctl and ethtool-nl would be hacked up ethtool binaries
> which only use one mechanism instead of trying to autoselect.
I have rechecked my assumptions that the EINVAL was propogating from the check
on the rx_count/tx_count and discovered that it wasn't. After I realised this,
I found that the interface I was trying to call ETHTOOL_SCHANNEL with doesn't
support that operation - there are 2 NICs in this test machine.
Apologies for the noise on the mailing list/your inboxes, I now have a fully
working ETHTOOL_GCHANNEL/ETHTOOL_SCHANNEL test harness (so long as I point my
code at the correct interface!)
Thanks,
Kev
next prev parent reply other threads:[~2021-06-16 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 6:30 ethtool discrepancy between observed behaviour and comments Kev Jackson
2021-06-15 19:40 ` Jakub Kicinski
2021-06-16 9:50 ` Kev Jackson [this message]
2021-06-15 23:22 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMnJbl1KiB4EaPVP@linux-dev \
--to=foamdino@gmail.com \
--cc=kuba@kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).