From: Andrew Lunn <andrew@lunn.ch>
To: "Marek Behún" <kabel@kernel.org>
Cc: Kurt Cancemi <kurt@x64architecture.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH 1/1] net: phy: marvell: Fixed handing of delays with plain RGMII interface
Date: Tue, 29 Jun 2021 17:08:48 +0200 [thread overview]
Message-ID: <YNs3gI9A6e4QkTrj@lunn.ch> (raw)
In-Reply-To: <20210629125234.7fcfc6bb@thinkpad>
On Tue, Jun 29, 2021 at 12:52:34PM +0200, Marek Behún wrote:
> On Mon, 28 Jun 2021 21:12:41 -0400
> Kurt Cancemi <kurt@x64architecture.com> wrote:
>
> > I am using drivers/net/ethernet/freescale/dpaa. This is a T2080 soc.
> >
> > The following is where I added a dev_info statement for "phy_if", it
> > correctly returned -> PHY_INTERFACE_MODE_RGMII_ID.
> > https://github.com/torvalds/linux/blob/master/drivers/net/ethernet/freescale/fman/mac.c#L774
>
> It seem that dpaa / fman drivers do the same thing for both
> "rgmii" and "rgmii-id". There should be code that enables the delays
> for the "rgmii-id" variant...
Generally, the MAC does nothing, and asks the PHY to do the delay. So
in the MAC driver there should be nothing, apart from pass phy-mode to
the PHY.
Andrew
prev parent reply other threads:[~2021-06-29 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 19:28 [PATCH 0/1] Possible Issue Setting the Delay Flags in the Marvell Net PHY Driver Kurt Cancemi
2021-06-28 19:28 ` [PATCH 1/1] net: phy: marvell: Fixed handing of delays with plain RGMII interface Kurt Cancemi
2021-06-28 22:49 ` Marek Behún
2021-06-28 23:01 ` Marcin Wojtas
2021-06-29 0:05 ` Kurt Cancemi
2021-06-29 0:21 ` Marek Behún
[not found] ` <CADujJWWoWRyW3S+f3F_Zhq9H90QZ1W4eu=5dyad3DeMLHFp2TA@mail.gmail.com>
2021-06-29 0:23 ` Marek Behún
2021-06-29 1:12 ` Kurt Cancemi
2021-06-29 10:52 ` Marek Behún
2021-06-29 15:08 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNs3gI9A6e4QkTrj@lunn.ch \
--to=andrew@lunn.ch \
--cc=kabel@kernel.org \
--cc=kurt@x64architecture.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).